Repository navigation
[v0.2] Choose a saved profile as a jump hop in the form - #32
Merged
Merged
Conversation
The connection form gains a Jump selector: direct, one entry per saved connection, and custom for a pasted or already-saved chain. Pasting a chain into Host still wins, editing a profile-backed hop selects that profile, and an unresolvable reference is shown rather than hidden. Refs #27 Signed-off-by: Xingqiu Xu <hilbertanjou83@gmail.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent: #1
Closes #27
What changed
Jumpselector in the connection form, rendered inline asJump ‹ … ›:direct,custom (n hops)for a pasted or already-saved chain.FormStategainsjump: JumpChoice { Direct, Profile(id), Custom }, derived from the saved chain when editing: empty →Direct, a single profile hop → that profile, anything else →Custom.Authenticationand key-source selectors; the field joins the Tab order between Port and Authentication.draft()maps the choice back to a chain. A chain pasted into the Host field still wins over the selector, because that paste is explicit input — the existing paste tests keep passing unchanged.missing (<id>)in the form, which is the same wording the browse detail uses.Layout
This is where the ticket earned its keep. The form is a fixed-height stack with hard-coded body heights per auth mode, and the first attempt (a hint row, a selector row, and a blank separator) broke four layout regressions — at 56x22 and at 40 columns the public-key box was pushed out of the visible body. The shipped version is a single inline row, which costs exactly one row: the jump block reuses the row structure above Authentication, and every
body_heightgrows by one.editor_stays_content_sized_on_large_terminalswas updated to the new content height (20 → 21) because that is precisely what it measures.Verification
cargo test --all-targets --locked(123 lib tests plus every integration suite),cargo clippy --all-targets --all-features --locked -- -D warnings,cargo +1.88.0 check --all-targets --locked,cargo fmt --check.directclearing a saved chain, pasted chain beating the selector, editing profile-backed and pasted chains, form rendering of a selected profile and of a missing one, and the layout regressions that pinned the sizing.