Repository navigation
[v0.2] Show jump chains in the TUI - #31
Merged
Merged
Conversation
The detail block gains a Jump row: 'direct' for a plain connection, endpoint hops in connection order, profile-backed hops by the referenced connection's name, and an explicit marker when a reference no longer resolves. Narrow and dense layouts keep their single-row address. Refs #13 Signed-off-by: Xingqiu Xu <hilbertanjou83@gmail.com>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent: #1
Closes #13
What changed
Jumprow, using the free third row of the roomy layout:Jump directfor a connection without hops;Jump root@124.222.134.112:2222 → Bastion— endpoint hops render their authority in connection order, profile-backed hops render the referenced connection's name, and a reference that no longer resolves rendersmissing (<id>)rather than a blank.width - 4 < 66) and dense (shell height < 16) layouts collapse the detail block to one row; the jump row is skipped there so the address stays readable, which is what the existing layout regression tests pin down.Scope note
The ticket also asked for the edit-form display. That row is deliberately not added here: the form is a fixed-height stack whose row offsets and body heights are hard-coded per auth mode, and #27 has to add a selectable jump field there anyway. A read-only row would be replaced by #27's field within a ticket, so the form half of this acceptance moves into #27. Issue #13 has been updated to record that.
Verification
cargo test --all-targets --locked(115 lib tests plus every integration suite),cargo clippy --all-targets --all-features --locked -- -D warnings,cargo fmt --check.