Repository navigation
[v0.2] Add multi-distribution package smoke tests - #23
Merged
Merged
Conversation
Move the in-container install checks into packaging/smoke so they can be reviewed and run locally, drive them from one ARM64 matrix covering debian, ubuntu, fedora, and rocky, and assert 'line --list' next to 'line --version' on every distribution image. Assert static linkage where the binary is built, with readelf instead of ldd, because busybox ldd reports a loader for static-pie binaries. Refs #9 Signed-off-by: Xingqiu Xu <hilbertanjou83@gmail.com>
Lingbou
force-pushed
the
feat/distro-package-matrix
branch
from
September 30, 2026 11:54
e2868b0 to
2a0be29
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent: #1
Closes #9
What changed
packaging/smoke/(lib.shplus one script per artifact kind), so they are reviewable and runnable locally instead of being generated as heredocs inside the workflow.deb-installandrpm-installcollapse into a singlepackage-installmatrix on the native arm64 runner coveringdebian:bookworm-slim,ubuntu:24.04,fedora:latest, androckylinux:9. Adding a distribution is one matrix entry.line --version(shape-checked) andline --list.packagejob, right after the build, usingreadelf: noINTERPprogram header, noNEEDEDentries.dpkg -istep in thepackagejob is gone; the container matrix covers it with dependency resolution.packagejob installsbinutilsexplicitly forreadelf.Why readelf instead of ldd
lddis not a reliable static-linkage oracle across images. Glibc'slddreports "statically linked" for our static-pie build, but busyboxlddon Alpine prints the musl loader path for the same binary, which made the Alpine leg of the tarball job fail on a perfectly static artifact. Checking the ELF directly forINTERPandNEEDEDgives the same verdict everywhere, and it now runs where the binary is built, so the signal is available for every artifact kind (deb, rpm, tarball) rather than only inside the containers that happen to have glibc.Runtime
The install jobs only pull a base image and the distribution's OpenSSH packages; the expensive compilation stays in the
packagejob and is shared through the uploaded artifacts. Each container leg finishes in well under a minute.Verification
actionlintclean.debian,ubuntu,fedora,rockylinux,alpine,archlinux) after the refactor; thereadelfassertions were negative-tested against a dynamically linked binary."$var:ro"applies the zsh:rmodifier, so local harnesses must quote as"${var}:ro". CI runs bash, so the workflows are unaffected.