-
Notifications
You must be signed in to change notification settings - Fork 94
fix: uthash update and buffer overflow found #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Piloalucard
wants to merge
9
commits into
LinearTapeFileSystem:v2.4.8-windows-support
Choose a base branch
from
Piloalucard:chore/uthash-and-cwe
base: v2.4.8-windows-support
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
bb4d444
enhancing for cwes found
Piloalucard aa678e0
Update uthash.h
Piloalucard 87b0cee
Reverting unneccesary changes
Piloalucard 11074ab
Update uthash.h
Piloalucard d5382d5
uthash as submodule
Piloalucard be3bfe0
Refactor of macros
Piloalucard 2078488
Handling object
Piloalucard b38e8b7
Update uthash_nonfatal_oom macro definition
Piloalucard 5eaa01f
Modify uthash_nonfatal_oom to suppress unused variable warning
Piloalucard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| # Ensure .gitmodules always uses LF line endings | ||
| .gitmodules text eol=lf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| name: Update uthash.h from submodule | ||
|
|
||
| on: | ||
| schedule: | ||
| - cron: '0 0 * * 0' # Weekly on Sunday at midnight UTC | ||
| workflow_dispatch: # Allow manual trigger | ||
| push: | ||
| paths: | ||
| - '.gitmodules' | ||
| - 'src/libltfs/uthash_submodule/**' | ||
|
|
||
| jobs: | ||
| update-uthash: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| submodules: recursive | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Update submodule to latest | ||
| run: | | ||
| git submodule update --remote --merge src/libltfs/uthash_submodule | ||
| git add src/libltfs/uthash_submodule | ||
|
|
||
| - name: Check for changes | ||
| id: check_changes | ||
| run: | | ||
| git diff --cached --quiet || echo "changed=true" >> $GITHUB_OUTPUT | ||
|
|
||
| - name: Create Pull Request | ||
| if: steps.check_changes.outputs.changed == 'true' | ||
| uses: peter-evans/create-pull-request@v5 | ||
| with: | ||
| commit-message: 'chore: update uthash.h from upstream' | ||
| title: 'chore: update uthash.h from upstream' | ||
| body: | | ||
| Automated update of uthash.h from the official uthash repository. | ||
|
|
||
| This PR updates `src/libltfs/uthash.h` to the latest version from the uthash submodule. | ||
|
|
||
| **Changes:** | ||
| - Updated uthash submodule to latest commit | ||
| - Copied uthash.h from submodule to src/libltfs/ | ||
|
|
||
| **Note:** The OOM handling macros are defined in `uthash_ext.h` and remain unchanged. | ||
| branch: automated/update-uthash | ||
| delete-branch: true | ||
|
|
||
| # Made with Bob |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [submodule "src/libltfs/uthash_repo"] | ||
| path = src/libltfs/uthash_submodule | ||
| url = https://github.com/troydhanson/uthash.git | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a note, all files of this uthash.git repo will now be part of the ltfs project not only the requested header file, for example, they will be listed by default for IDLEs such as Visual Studio Code