Skip to content

fix: address transport handshake review feedback - #48

Merged
zchuango merged 3 commits into
LinQuickDev:transport-handshakefrom
Spicy-cream:review/pr3535-copilot-fixes
Sep 14, 2026
Merged

zchuango merged 3 commits into
LinQuickDev:transport-handshakefrom
Spicy-cream:review/pr3535-copilot-fixes

Conversation

@Spicy-cream

@Spicy-cream Spicy-cream commented Sep 14, 2026

Copy link
Copy Markdown

Summary

Address review feedback on transport handshake feedback.

Changes

  • Make upgrade capability checks transport-mode specific.
  • Prevent RDMA and UBSHM adapters from being selected for the wrong transport.
  • Safely encode short UBSHM shared-memory names.
  • Retry interrupted handshake reads and writes.
  • Publish handshake phase transitions with release ordering.
  • Release RDMA and UBSHM resources when negotiation falls back to TCP.
  • Add regression tests for mode-specific dispatch and short UBSHM names.

Validation

  • Build: passed.
  • Common transport handshake tests: 17/17 passed.
  • UBSHM/UBRING tests: 15/15 passed.
  • RDMA tests: 86/86 passed.

This PR targets the source branch used by apache#3535.

@zchuango
zchuango merged commit fcdd3e7 into LinQuickDev:transport-handshake Sep 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants