feat: add common transport-level handshake for RDMA and UBSHM - #46
Merged
zchuango merged 3 commits intoSep 11, 2026
Merged
Conversation
Spicy-cream
force-pushed
the
community/common-handshake-rdma
branch
3 times, most recently
from
September 11, 2026 10:02
9e11eb3 to
1a2bc22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the transport-level handshake design discussed in apache/brpc#3432.
It introduces a common handshake framework above individual high-speed transports and migrates both RDMA and UBSHM handshake orchestration to that framework. TCP remains the control-plane transport during negotiation and is retained when a high-speed transport is unavailable or negotiation falls back.
This is a cleaned and consolidated version of #35.
Main changes
AdapterTransportas the top-level transport for TCP, RDMA, and UBSHM sockets.RdmaEndpoint.UBShmEndpoint.Validation
WITH_RDMA=ON,WITH_UBRING=ON,BUILD_UNIT_TESTS=ON: configured and built successfully.Scope
This PR contains the common transport-handshake infrastructure together with the RDMA and UBSHM migrations.
URMA migration is intentionally left for a follow-up change.