feat: integrate optional FlatBuffers RPC support with regression tests - #45
Open
Spicy-cream wants to merge 9 commits into
Open
feat: integrate optional FlatBuffers RPC support with regression tests#45Spicy-cream wants to merge 9 commits into
Spicy-cream wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更目的
为社区提供可选启用的 FlatBuffers RPC 原型,并补齐消息所有权和请求拒绝路径的回归验证。本实现基于 apache#3196、apache#3197。
相关设计讨论:#44。
主要改动
本地验证
测试覆盖消息生命周期、移动所有权、损坏根偏移、正常 RPC、EREQUEST 返回及拒绝后正常调用。RPC 测试使用本地动态端口并禁用重试。
ctest --test-dir build-flatbuffers-tests-on \ -R '^brpc_flatbuffers_(message|rpc)_unittest$' \ --timeout 60 --output-on-failure最近已验证提交:0f591739。验证环境为 Ubuntu 24.04 WSL2、GCC 13.3、Protobuf 3.21.12、FlatBuffers 25.12.19。
评审边界
远端分支还包含进展文档提交 032119c;代码测试结果对应 0f59173。