Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR performs a coordinated version bump across 17 SDK library packages. Most crates transition from 0.22.0 to 0.23.0, while instruction-decoder-derive bumps from 0.3.0 to 0.4.0, photon-api from 0.55.0 to 0.56.0, and token-sdk from 0.22.1 to 0.23.0. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
sdk-libs/sdk/Cargo.toml (1)
30-30: 🧹 Nitpick | 🔵 TrivialConsider making
cpi-contextdepend onv2feature.Per coding guidelines, when using
cpi-context, thev2feature must also be enabled. Currently, if a user explicitly enables onlycpi-context(e.g.,default-features = false, features = ["cpi-context"]), they won't getv2. Whilev2is the default, an explicit dependency would be more robust:-cpi-context = ["light-sdk-types/cpi-context"] +cpi-context = ["v2", "light-sdk-types/cpi-context"]This prevents misconfigurations when users opt out of defaults. As per coding guidelines: "When using
cpi-contextfeature, ensure thev2feature is also enabled as it is a requirement."🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@sdk-libs/sdk/Cargo.toml` at line 30, The cpi-context feature should require the v2 feature to prevent users enabling cpi-context without v2; update the Cargo.toml features entry for cpi-context (the cpi-context feature definition in sdk-libs/sdk/Cargo.toml) so that the cpi-context feature list includes "v2" in addition to "light-sdk-types/cpi-context" (i.e., make cpi-context depend on v2).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@sdk-libs/sdk/Cargo.toml`:
- Line 30: The cpi-context feature should require the v2 feature to prevent
users enabling cpi-context without v2; update the Cargo.toml features entry for
cpi-context (the cpi-context feature definition in sdk-libs/sdk/Cargo.toml) so
that the cpi-context feature list includes "v2" in addition to
"light-sdk-types/cpi-context" (i.e., make cpi-context depend on v2).
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (3)
Cargo.lockis excluded by!**/*.lockand included by noneCargo.tomlis excluded by none and included by nonescripts/sdk-libs-changed-since-tag.shis excluded by none and included by none
📒 Files selected for processing (17)
sdk-libs/account-pinocchio/Cargo.tomlsdk-libs/account/Cargo.tomlsdk-libs/client/Cargo.tomlsdk-libs/compressed-token-sdk/Cargo.tomlsdk-libs/event/Cargo.tomlsdk-libs/instruction-decoder-derive/Cargo.tomlsdk-libs/instruction-decoder/Cargo.tomlsdk-libs/macros/Cargo.tomlsdk-libs/photon-api/Cargo.tomlsdk-libs/program-test/Cargo.tomlsdk-libs/sdk-pinocchio/Cargo.tomlsdk-libs/sdk-types/Cargo.tomlsdk-libs/sdk/Cargo.tomlsdk-libs/token-client/Cargo.tomlsdk-libs/token-pinocchio/Cargo.tomlsdk-libs/token-sdk/Cargo.tomlsdk-libs/token-types/Cargo.toml
Bumps all sdk-libs from 0.22.x to 0.23.0:
Summary by CodeRabbit