chore: rm decompressInterface. house keeping by SwenSchaeferjohann · Pull Request #2297 · Lightprotocol/light-protocol

SwenSchaeferjohann · 2026-02-18T19:15:14Z

rm decompressInterface

coderabbitai · 2026-02-18T19:15:21Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (50)

js/compressed-token/CHANGELOG.md is excluded by none and included by none
js/compressed-token/package.json is excluded by none and included by none
js/compressed-token/src/index.ts is excluded by none and included by none
js/compressed-token/src/v3/actions/create-associated-ctoken.ts is excluded by none and included by none
js/compressed-token/src/v3/actions/decompress-interface.ts is excluded by none and included by none
js/compressed-token/src/v3/actions/decompress-mint.ts is excluded by none and included by none
js/compressed-token/src/v3/actions/get-or-create-ata-interface.ts is excluded by none and included by none
js/compressed-token/src/v3/actions/index.ts is excluded by none and included by none
js/compressed-token/src/v3/actions/load-ata.ts is excluded by none and included by none
js/compressed-token/src/v3/actions/mint-to-compressed.ts is excluded by none and included by none
js/compressed-token/src/v3/actions/transfer-interface.ts is excluded by none and included by none
js/compressed-token/src/v3/actions/unwrap.ts is excluded by none and included by none
js/compressed-token/src/v3/actions/update-metadata.ts is excluded by none and included by none
js/compressed-token/src/v3/actions/update-mint.ts is excluded by none and included by none
js/compressed-token/src/v3/assert-v2-only.ts is excluded by none and included by none
js/compressed-token/src/v3/ata-utils.ts is excluded by none and included by none
js/compressed-token/src/v3/derivation.ts is excluded by none and included by none
js/compressed-token/src/v3/errors.ts is excluded by none and included by none
js/compressed-token/src/v3/get-account-interface.ts is excluded by none and included by none
js/compressed-token/src/v3/instructions/create-associated-ctoken.ts is excluded by none and included by none
js/compressed-token/src/v3/instructions/create-decompress-interface-instruction.ts is excluded by none and included by none
js/compressed-token/src/v3/instructions/create-load-accounts-params.ts is excluded by none and included by none
js/compressed-token/src/v3/instructions/create-mint.ts is excluded by none and included by none
js/compressed-token/src/v3/instructions/decompress-mint.ts is excluded by none and included by none
js/compressed-token/src/v3/instructions/freeze-thaw.ts is excluded by none and included by none
js/compressed-token/src/v3/instructions/index.ts is excluded by none and included by none
js/compressed-token/src/v3/instructions/mint-to-compressed.ts is excluded by none and included by none
js/compressed-token/src/v3/instructions/update-metadata.ts is excluded by none and included by none
js/compressed-token/src/v3/instructions/update-mint.ts is excluded by none and included by none
js/compressed-token/src/v3/layout/layout-mint-action.ts is excluded by none and included by none
js/compressed-token/src/v3/layout/layout-mint.ts is excluded by none and included by none
js/compressed-token/src/v3/layout/layout-transfer2.ts is excluded by none and included by none
js/compressed-token/src/v3/layout/serde.ts is excluded by none and included by none
js/compressed-token/src/v3/unified/index.ts is excluded by none and included by none
js/compressed-token/src/v3/utils/estimate-tx-size.ts is excluded by none and included by none
js/compressed-token/tests/e2e/compressible-load.test.ts is excluded by none and included by none
js/compressed-token/tests/e2e/decompress2.test.ts is excluded by none and included by none
js/compressed-token/tests/e2e/freeze-thaw-ctoken.test.ts is excluded by none and included by none
js/compressed-token/tests/e2e/get-account-interface.test.ts is excluded by none and included by none
js/compressed-token/tests/e2e/load-ata-freeze.test.ts is excluded by none and included by none
js/compressed-token/tests/e2e/load-ata-spl-t22.test.ts is excluded by none and included by none
js/compressed-token/tests/e2e/load-ata-standard.test.ts is excluded by none and included by none
js/compressed-token/tests/e2e/multi-cold-inputs-batching.test.ts is excluded by none and included by none
js/compressed-token/tests/e2e/payment-flows.test.ts is excluded by none and included by none
js/compressed-token/tests/e2e/transfer-interface.test.ts is excluded by none and included by none
js/compressed-token/tests/e2e/unwrap.test.ts is excluded by none and included by none
js/compressed-token/tests/e2e/v3-interface-migration.test.ts is excluded by none and included by none
js/compressed-token/tests/e2e/wrap.test.ts is excluded by none and included by none
js/compressed-token/tests/unit/delegate-merge-semantics.test.ts is excluded by none and included by none
js/compressed-token/tests/unit/load-transfer-cu.test.ts is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch swen/hardening-ts

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

test cov: offcurve, zero-amounts test cov: dupe hash failure, v1 reject at ixn boundary more test cov load, add freeze thaw, extend test cov add tests lint frozen handling more tests mark internals rm _tryfetchctokencoldbyaddress cleanups fmt

ananas-block · 2026-02-24T17:59:38Z

js/compressed-token/src/v3/actions/transfer-interface.ts

+     * For load: use this owner for getAtaInterface; only sources the delegate
+     * can use are included. For transfer: see TransferOptions.owner.
+     */
+    owner?: PublicKey;


The comment and naming are not completely clear.
I think in the spl program this field would be called authority (either owner or delegate).
Do you need the owner to derive the ata pubkey?

ananas-block · 2026-02-24T18:00:44Z

js/compressed-token/src/v3/actions/transfer-interface.ts

+    /**
+     * ATA owner when the signer is the delegate (not the owner).
+     * Required when transferring as delegate: pass the owner so the SDK
+     * can derive the source ATA and validate the signer is the account delegate.
+     */
+    owner?: PublicKey;


SwenSchaeferjohann marked this pull request as ready for review February 19, 2026 00:54

SwenSchaeferjohann force-pushed the swen/hardening-ts branch from 791e89a to 541d059 Compare February 23, 2026 14:20

rm decompressinterface

1b34488

test cov: offcurve, zero-amounts test cov: dupe hash failure, v1 reject at ixn boundary more test cov load, add freeze thaw, extend test cov add tests lint frozen handling more tests mark internals rm _tryfetchctokencoldbyaddress cleanups fmt

SwenSchaeferjohann force-pushed the swen/hardening-ts branch from 541d059 to 1b34488 Compare February 23, 2026 15:13

SwenSchaeferjohann added 4 commits February 23, 2026 15:59

unwrap consistent

61de49e

remove createLoadAccountsParams

03c48a7

add uni err

ed565b9

fix

dde5ccc

ananas-block reviewed Feb 24, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

chore: rm decompressInterface. house keeping#2297

chore: rm decompressInterface. house keeping#2297
SwenSchaeferjohann wants to merge 5 commits intomainfrom
swen/hardening-ts

SwenSchaeferjohann commented Feb 18, 2026

Uh oh!

coderabbitai bot commented Feb 18, 2026 •

edited

Loading

Review skipped

Uh oh!

ananas-block Feb 24, 2026 •

edited

Loading

Uh oh!

ananas-block Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

SwenSchaeferjohann commented Feb 18, 2026

Uh oh!

coderabbitai bot commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

ananas-block Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ananas-block Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Feb 18, 2026 •

edited

Loading

ananas-block Feb 24, 2026 •

edited

Loading