Add item requests and gateway#3
Merged
LightInTheFire merged 23 commits intomainfrom Mar 19, 2026
Merged
Conversation
Owner
Author
|
Покройте тестами пожалуйста КАЖДУЮ КОЧКУ спасибо |
Ivanov-s-tmn
left a comment
Ivanov-s-tmn
left a comment
There was a problem hiding this comment.
Илья, привет! Все отлично, но не хватает интеграционных тестов по сервисам (без моков). В ТЗ есть требование реализовать хотя бы по одному интеграционному тесту для одного из методов каждого сервиса
Comment on lines
+32
to
+39
| @Autowired | ||
| private UserRepository userRepository; | ||
|
|
||
| @Autowired | ||
| private ItemRepository itemRepository; | ||
|
|
||
| @Autowired | ||
| private BookingRepository bookingRepository; |
There was a problem hiding this comment.
Сторонние зависимости в интеграционных тестах внедрять не стоит, мы должны протестировать взаимодействие с БД конкретного сервиса, поэтому все остальные сущности добавляются в БД для тестов отдельными sql скриптами или через EntityManager/TestEntityManager
Так тесты будут менее зависимы от других сервисов, более стабильны, просты и прогнозируемы
Owner
Author
There was a problem hiding this comment.
Хорошо, поправлю, спасибо!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Добавил реквесты предметов.
Разбил проект на два модуля, запустить все контейнеры можно одним docker compose из корня проекта
МНОГО ТЕСТОВ