DomElement: Ignore garbage bytes \x0C and \x06 in XML files#20
Merged
DomElement: Ignore garbage bytes \x0C and \x06 in XML files#20
Conversation
It seems that some EAGLE projects (maybe only the Arduino Nano schematic?) contain garbage bytes, effectively making the XML invalid and the parser failing. Thus now stripping those two garbage bytes from the input data.
ubruhin
force-pushed
the
xml-sanity-check
branch
from
0cb416f to
5ad24f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that some EAGLE projects (maybe only the Arduino Nano schematic?) contain garbage bytes, effectively making the XML invalid and the parser failing. Thus now stripping those two garbage bytes from the input data.
See https://gitlab.com/kicad/code/kicad/-/work_items/11008