Repository navigation
Conversation
Contributor
|
Reviewed head 058029f. Restored sessions can retain node_modules links to the previous runtime and lose ESM imports after an image rebuild. Prerequisite #347 fixes that migration; recommend landing it first. Local qualification passes: 51 worker tests on each patched Node version, 14 extraction tests on Node 24.22.1, 15 service-config tests, Helm runtime selection, all sandbox Dockerfile checks, the Node 22.23.4 native-addon/packaged IPC smoke, and extraction container security/restart checks including 75 adversarial fixtures. The CI, Images, and Extraction Service runs still require fork-workflow approval. API and service typechecks each have seven baseline diagnostics, confirmed against main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔒 fix: Bump Node to 22.23.4 / 24.22.1 for October 2026 security release
Node.js published security releases on 2026-10-21 covering, among
others, CVE-2026-111497 (Brotli out-of-bounds write / RCE),
CVE-2026-105481, CVE-2026-105482, CVE-2026-105483, CVE-2026-106069,
CVE-2026-106070, CVE-2026-106072 and CVE-2026-106074, plus bundled
dependency updates for OpenSSL, c-ares, SQLite, undici and the CA
store (eMudhra intermediate CA compromise).
https://nodejs.org/en/blog/vulnerability/october-2026-security-releases
Sandbox runtime (user code):
24.15.0 -> 24.22.1
24.22.1 so requests resolve to the newly installed runtime
Container images:
node:22.23.4-slim (node binary + headers copied into the rootfs)
node:24.22.1-bookworm-slim
CI:
Floating tags are pinned to the patched releases so a cached layer or
stale mirror cannot resolve to a pre-fix image.
These are patch releases within the same majors, so NODE_MODULE_VERSION
is unchanged (127 for 22.x, 137 for 24.x) and native addons such as
anonymous-pipes.node keep loading without a rebuild.
Upgrade note: the sandbox runtime now installs to /pkgs/node/24.22.1.
Existing deployments need package-init to run again (Helm job or
baked image rebuild) before the new version is selectable.