Review GitHub actions#209
Merged
Merged
Conversation
Collaborator
Author
|
Build time decreased from 30 minutes to 5 minutes. |
Collaborator
|
Wau, quite an improvement. |
Collaborator
|
@colisee Since I hate merge commits I rebased it... |
JohnVillalovos
approved these changes
Jun 16, 2026
JohnVillalovos
left a comment
Collaborator
There was a problem hiding this comment.
@colisee LGTM.
I just had one question on why the schedule was removed. But I still approve.
Thanks.
| name: Build release image | ||
|
|
||
| on: | ||
| schedule: |
Collaborator
There was a problem hiding this comment.
Why is the schedule being removed?
Collaborator
Author
I decided to remove the schedule for release images because we could end up with different images (caused by apt-get update && apt-get upgrade) while bearing the same image tag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes