Skip to content

Review GitHub actions#209

Merged
colisee merged 7 commits into
LibreBooking:masterfrom
colisee:actions
Jun 16, 2026
Merged

Review GitHub actions#209
colisee merged 7 commits into
LibreBooking:masterfrom
colisee:actions

Conversation

@colisee

@colisee colisee commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Changes

  • Drop arm32 build
  • Parallelize amd64 and arm64 builds
  • Rename some repository variables for consistency
  • Drop scheduling trigger for releases (they are built only once)
  • Bump default php version to 8.5.7

@colisee colisee requested review from JohnVillalovos and ikke-t June 16, 2026 13:37
@colisee

colisee commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator Author

Build time decreased from 30 minutes to 5 minutes.

@ikke-t ikke-t left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ikke-t

ikke-t commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Wau, quite an improvement.

@JohnVillalovos

Copy link
Copy Markdown
Collaborator

@colisee Since I hate merge commits I rebased it...

@JohnVillalovos JohnVillalovos left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colisee LGTM.

I just had one question on why the schedule was removed. But I still approve.

Thanks.

name: Build release image

on:
schedule:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the schedule being removed?

@colisee

colisee commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator Author

@colisee LGTM.

I just had one question on why the schedule was removed. But I still approve.

Thanks.

I decided to remove the schedule for release images because we could end up with different images (caused by apt-get update && apt-get upgrade) while bearing the same image tag.

@colisee colisee merged commit 1c559bd into LibreBooking:master Jun 16, 2026
3 checks passed
@colisee colisee deleted the actions branch June 16, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants