Skip to content

fix(build_sys): install the intl PHP extension#208

Merged
colisee merged 1 commit into
masterfrom
jlvillal/intl
Jun 16, 2026
Merged

fix(build_sys): install the intl PHP extension#208
colisee merged 1 commit into
masterfrom
jlvillal/intl

Conversation

@JohnVillalovos

Copy link
Copy Markdown
Collaborator

Upstream made the intl PHP extension a requirement[1]. Update the build script to install it.

  1. In commit ccd90236dc64645f3889e4efb684493dde68c949 in LibreBooking: LibreBooking/librebooking@ccd9023

Upstream made the `intl` PHP extension a requirement[1]. Update the build
script to install it.

1. In commit ccd90236dc64645f3889e4efb684493dde68c949 in LibreBooking:
LibreBooking/librebooking@ccd9023
Copilot AI review requested due to automatic review settings June 16, 2026 03:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JohnVillalovos JohnVillalovos requested a review from colisee June 16, 2026 03:24

@colisee colisee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JohnVillalovos
LGTM

@colisee colisee merged commit 095653a into master Jun 16, 2026
5 of 6 checks passed
@colisee colisee deleted the jlvillal/intl branch June 16, 2026 09:15
@colisee

colisee commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

@JohnVillalovos , I am afraid I should have checked the logs of the last develop image build before validating the change. It looks like composer install fails:

Root composer.json requires PHP extension ext-intl * but it is missing from your system. Install or enable PHP's intl extension.

I need to understand what's wrong here. An alternative (too be considered last) is to use composer install --ignore-platform-req=ext-intl

@colisee

colisee commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

@JohnVillalovos , forget my stupid previous comment!
The explanation for the failure was that this morning scheduled action ran against the new upstream (with the new intl composer requirement) while the script build_sys.sh was still pending my approval!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants