perf(core): avoid per-ref string allocations via PdfRef.key#62
Open
ntedvs wants to merge 1 commit intoLibPDF-js:mainfrom
Open
perf(core): avoid per-ref string allocations via PdfRef.key#62ntedvs wants to merge 1 commit intoLibPDF-js:mainfrom
ntedvs wants to merge 1 commit intoLibPDF-js:mainfrom
Conversation
Ref identity Maps/Sets were keyed on template strings like "${objNum} ${gen}", allocating a string per visit. Introduce PdfRef.key, a packed numeric identity (objNum * 65536 + gen, lossless since PDF caps generation at 65535), and migrate the two hottest call sites: collectReachableRefs in the writer GC walk, and the parser's object cache plus page-tree visitor.
Measured on the same machine:
- load heavy PDF (9.9MB): +13.5%
- load small/medium/form PDF: +9 to 10%
- save heavy PDF (9.9MB): +7%
- save with modifications (19KB): +3%
Contributor
|
@ntedvs is attempting to deploy a commit to the mythie's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref identity Maps/Sets were keyed on template strings like "${objNum} ${gen}", allocating a string per visit. Introduce PdfRef.key, a packed numeric identity (objNum * 65536 + gen, lossless since PDF caps generation at 65535), and migrate the two hottest call sites: collectReachableRefs in the writer GC walk, and the parser's object cache plus page-tree visitor.
Measured on the same machine: