Draft
Conversation
FreebieII
approved these changes
Apr 24, 2023
JasonLovesDoggo
requested changes
Mar 31, 2025
|
|
||
| def __init__(self, bot: OGIROID): | ||
| self.bot = bot | ||
| self.count = 1 |
Member
There was a problem hiding this comment.
dont store state in memory. We have a database, use it
| async for message in self.channel.history(limit=10): | ||
| if message.author.bot: | ||
| continue | ||
| if message.content.isdigit(): |
| return | ||
| messages = await self.channel.history(limit=1).flatten() | ||
| last_message = messages[1] | ||
| print(f"{last_message.author.name}: {last_message.content}") |
| if message.author.bot or not message.content.isdigit(): | ||
| return | ||
| messages = await self.channel.history(limit=1).flatten() | ||
| last_message = messages[1] |
Member
There was a problem hiding this comment.
just... use the message arg passed into the function
| messages = await self.channel.history(limit=1).flatten() | ||
| last_message = messages[1] | ||
| print(f"{last_message.author.name}: {last_message.content}") | ||
| if last_message.author == message.author and last_message.content.isdigit(): |
Member
There was a problem hiding this comment.
duplicate isdigit calls
| elif message.content == str(self.count): | ||
| self.count += 1 | ||
| # Add checkmark reaction | ||
| await message.add_reaction("✅") |
Member
There was a problem hiding this comment.
uh- I would have this be set for a channel. If the content isn't a num. delete it. No reactions
| if last_message.author == message.author and last_message.content.isdigit(): | ||
| embed = Embed( | ||
| title="Counting Game", | ||
| description=f"{message.author.mention}, you can't do this alone!", |
Member
There was a problem hiding this comment.
no reason to not support an author sending multiple consecutive msgs
| ) | ||
| await self.channel.send(embed=embed) | ||
| self.count = 1 | ||
| # TODO Implement leaderboard with db |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.