Soft-deprecate the concatenate artifact-removal method (#354)#396
Merged
Conversation
Flip the removeArtifacts method default from "concatenate" to "replace with NaN" and update the help text to discourage "concatenate", which re-times the kept samples onto a fresh timeline and breaks alignment to the acquisition clock. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
pauladkisson
force-pushed
the
fix-354-artifact-default
branch
from
July 23, 2026 15:04
2059aaa to
6a92ed5
Compare
pauladkisson
enabled auto-merge
July 23, 2026 15:07
The integration save-parameters test compares the written snapshot against the form defaults; flip its expected artifactsRemovalMethod to "replace with NaN" to match the new default. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from the stalled NWB-export PR #357 so the artifact fix can land in
mainon its own while the larger feature keeps cooking.Flips the
removeArtifacts methoddefault fromconcatenatetoreplace with NaNand reworks the help text to discourageconcatenate. See #354 for whyconcatenateis the wrong default — it re-times the kept samples onto a fresh timeline and breaks alignment to the acquisition clock.Scope is just the frontend default + help text and the matching unit-test assertion. The NWB-export-specific abort (which refuses to export a
concatenate-processed session) stays on the NWB-export branch, since it lives in a file that doesn't exist onmain.🤖 Generated with Claude Code