Skip to content

test(server): fold mockConfigStoreForHealth onto mocks.MockConfigStore #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IAmJSD merged 3 commits into from
Oct 26, 2026
Merged

test(server): fold mockConfigStoreForHealth onto mocks.MockConfigStore #1460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
184caca
test(server): embed mocks.MockConfigStore in mockConfigStoreForHealth
IAmJSD Oct 26, 2026
8895896
test(server): drop the last hand-written stubs from mockConfigStoreFo…
IAmJSD Oct 26, 2026
2f7bb08
Merge origin/main into fix/issue-76-rest
IAmJSD Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions internal/mocks/config_store_copies_guard_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,12 @@ import (
"testing"
)

// handRolledConfigStoreAllowlist lists the hand-rolled config.StoreInterface
// copies that predate this guard and are still waiting to be folded onto
// MockConfigStore (issue #76). It may only shrink: an entry whose type no
// longer hand-rolls the interface fails the guard until it is removed here.
var handRolledConfigStoreAllowlist = map[string]bool{
"internal/server.mockConfigStoreForHealth": true,
}
// handRolledConfigStoreAllowlist lists hand-rolled config.StoreInterface copies
// that are still waiting to be folded onto MockConfigStore (issue #76). It is
// empty now that internal/server.mockConfigStoreForHealth embeds
// MockConfigStore, and it may only shrink: an entry whose type no longer
// hand-rolls the interface fails the guard until it is removed here.
var handRolledConfigStoreAllowlist = map[string]bool{}

// TestNoHandRolledConfigStoreMocks keeps test doubles of config.StoreInterface
// from being written out method by method. Every such copy needs a new stub for
Expand Down
Loading
Loading