You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(history): truncation banner quotes the wrong cap and a failed class listing does not set truncated #686
Two small gaps left by #632 PR1 (PR #684): the History truncation banner quotes the wrong cap, and a failed class listing hides rows without raising truncated.
Current behaviour
frontend/src/history.ts:~396 renders "capped at ${executions_limit} pending, failed or other non-completed executions". After PR fix(history): fetch actionable executions separately so terminal rows cannot starve them #684, executions_limit (100) caps only the terminal class; actionable rows (pending, notified, scheduled, approved, running, paused) have a separate cap of MaxListLimit (1000). When only the actionable class hit its cap the banner still says 100.
fetchExecutionsByClass (internal/api/handler_history.go) logs a listing error and skips that class; truncated stays false. If the actionable query fails, pending approvals disappear with no signal in the response (no worse than before PR fix(history): fetch actionable executions separately so terminal rows cannot starve them #684, but it is the one remaining silent path).
Steps to verify the gap
Return 1000 actionable rows from the store: truncated is true but the banner text says 100.
Make the actionable GetExecutionsByStatuses call return an error: the response has no pending rows and truncated is false.
Expected behaviour
The banner states the cap that was actually hit (or the API exposes both caps).
A class listing error makes the response flag incomplete results (for example truncated=true), so the UI shows its banner.
In fetchExecutionsAsHistory set the cap signal when either fetchExecutionsByClass errors; add a test next to TestHandler_getHistory_ClassListingErrorKeepsOtherClass.
References
PR #684 review by cc-cli-w2 (notes A1 and R1), parent #632, umbrella #248, related #676 and #680. Severity: low.
Closing as fixed on main. #1276 (backend) sets truncated on a failed class listing and exposes actionable_executions_limit. #1358 (frontend, with #1277 paging) makes historyTruncationMessage quote actionable_executions_limit and mention a listing failure when truncated without more pages. Verified in frontend/src/history-paging.ts on main.
The fix PRs said Refs, so GitHub did not close this automatically. Checked against main on 2026-10-26 by IAmJSD's agent (IAmJSD is acting owner while the maintainers are away). Reopen if anything here is still wrong.
Activity
IAmJSD commentedon Oct 23, 2026
Claiming: working on this
Merge fix/issue-686 (with origin/main) into fix/issue-674
fix(history): flag a failed execution class listing as truncated and …
feat(api): page the History view with a keyset cursor (has_more, next…
IAmJSD commentedon Oct 26, 2026
Closing as fixed on main. #1276 (backend) sets truncated on a failed class listing and exposes actionable_executions_limit. #1358 (frontend, with #1277 paging) makes historyTruncationMessage quote actionable_executions_limit and mention a listing failure when truncated without more pages. Verified in frontend/src/history-paging.ts on main.
The fix PRs said Refs, so GitHub did not close this automatically. Checked against main on 2026-10-26 by IAmJSD's agent (IAmJSD is acting owner while the maintainers are away). Reopen if anything here is still wrong.