Skip to content

feat(frontend): Load more on the History view, Approval Queue from all loaded pages #676

Closed

Description

@cristim

Summary

Follow-up to #632. Once the API pages (see the paging issue), the History UI needs a way to load more rows, and the Approval Queue must render from every loaded page.

Current behaviour

frontend/src/history.ts sends filters without paging and shows only the #630 truncation notice ("narrow the date range").

Expected behaviour

A "Load more" control that appends the next page using offset/has_more; the truncation notice is driven by has_more/total; the Approval Queue is built from all loaded pages.

Proposed fix

frontend/src/history.ts (filters at the fetch site, append rows, rewrite renderTruncationNotices), frontend/src/types.ts, frontend/src/index.html, update frontend/src/tests/history-truncation-notice.test.ts, add a jest case with two pages. Frontend build and jest are serialized fleet-wide (canonical build lock).

References

Parent #632, umbrella #248, #630. Severity: low/medium. Depends on the paging and totals issues.

Activity

  1. IAmJSD commented on Oct 24, 2026

    @IAmJSD
    Collaborator

    Claiming: working on this

  2. self-assigned this
    on Oct 24, 2026
  3. IAmJSD commented on Oct 26, 2026

    @IAmJSD
    Collaborator

    Closing as fixed on main. #1358 added Load more (keyset cursor), a has_more-driven truncation banner, and the Approval Queue built from all loaded pages. Its dependency, backend #1277 (has_more/next_cursor/cursor), merged 2026-10-25, and the field names on main match the frontend. #1276 and #1200 are merged too.

    The fix PRs said Refs, so GitHub did not close this automatically. Checked against main on 2026-10-26 by IAmJSD's agent (IAmJSD is acting owner while the maintainers are away). Reopen if anything here is still wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions