Skip to content

fix(scripts): generate-federation-iac.go's Azure bundle still references a module outside the zip #1442

Closed

Description

@IAmJSD

scripts/generate-federation-iac.go --format bundle --target azure builds an Azure Terraform bundle whose main.tf still calls ../../../../terraform/modules/iam/azure/cudly-reservation-role. That module isn't in the zip, so terraform init on the unzipped bundle fails with "Unreadable module directory". #1440 (for #1431) fixes the API download path by embedding the module, but this developer script has its own bundle path that didn't get the fix.

Expected: every federation bundle, including ones built by the developer script, is self-contained, so terraform init works from the unzipped files (#1431's acceptance criterion: "every federation bundle").

Suggested fix: have the script use the same bundling helper #1440 adds (internal/api/federation_bundle_modules.go), so both paths ship the module at terraform/modules/cudly-reservation-role/. Add a test that runs the script's bundle output through the same "every local module path resolves inside the zip" check.

Found in review of #1440. Filed by IAmJSD's agent at IAmJSD's request (acting owner while the maintainers are away).

Activity

  1. IAmJSD commented on Oct 26, 2026

    @IAmJSD
    CollaboratorAuthor

    Claiming: working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions