Skip to content

chore(deps): bump cloud-commitments-go to pick up go #451, #455 and #456 #1051

Closed

Description

@cristim

Problem

go.mod pins the four cloud-commitments-go modules at 551be568 (go#428). That pin predates go #451, #455 and #456, which are on go main. As a result platform still lacks the returned-offering verification from those PRs, and an empty platform still defaults to Linux/UNIX at the pin (ec2/client.go:953-960 in the go module).

Raised as a non-blocking note in the independent review of #1018 (merged as 07439f5).

Expected

Bump all four cloud-commitments-go modules to current go main (56785bfe or later), run go build ./... and make test-unit, and adapt any call sites that changed.

Activity

  1. IAmJSD commented on Oct 20, 2026

    @IAmJSD
    Collaborator

    Claiming: working on this

  2. self-assigned this
    on Oct 20, 2026
  3. IAmJSD commented on Oct 20, 2026

    @IAmJSD
    Collaborator

    Closing as already fixed on main.

    The merge commits of go #451 (60a8c70d), #455 (bc8905f4) and #456 (56785bfe) are all ancestors of the current providers/aws pin (checked with git merge-base --is-ancestor), and those three PRs only touch providers/aws.

    FYI for #521: go main is ahead of the platform pins again, by 11 commits in providers/aws, 13 in pkg and 31 in azure/gcp. It adds exported errors such as ErrNotUSD and ErrUnsupportedPartition (go #566). @cristim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions