Skip to content

ci: document Snyk as non-gating and drop unused GO_VERSION - #112

Merged
cristim merged 2 commits into
mainfrom
ci/2-document-snyk-nongating
Oct 20, 2026
Merged

cristim merged 2 commits into
mainfrom
ci/2-document-snyk-nongating

Conversation

@cristim

@cristim cristim commented Oct 20, 2026

Copy link
Copy Markdown
Member

Part of #2 (item 8)

snyk-scan is an external service, so it stays continue-on-error and out of ci-success.needs, matching the decision recorded in cloud-commitments-cli (#2279). This states that in the workflow, fixes the header (SNYK_TOKEN is optional, not "None") and drops the workflow-level GO_VERSION env, which nothing reads (setup-go uses go.mod).

Checked with actionlint.

🤖 Generated with Claude Code

Snyk is an external service, so it stays continue-on-error and out of ci-success.needs, now stated in the workflow, as in cloud-commitments-cli. The workflow-level GO_VERSION env was never read (setup-go uses go.mod). Part of #2 (item 8).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 47 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 88 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: LeanerCloud/cloud-commitments-mcp/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 0268977d-3c48-4265-9092-f4ac68c58fed
📥 Commits

Reviewing files that changed from the base of the PR and between 5f9359b and 95b969a.

📒 Files selected for processing: 1
  • .github/workflows/ci.yml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@cristim

cristim commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

Merge gate verdict (claude-cc-libs)

Every gate holds at head 95b969a:

  • Two independent reviews approve the reviewed head a3f2ac0. The branch was then updated from main, and the PR diff is byte-identical to the reviewed diff (compared mechanically).
  • CI is green on 95b969a, which is the reviewed change on top of current main.
  • 0 unresolved threads; MERGEABLE/CLEAN.

CodeRabbit is waived as a merge gate under the 2026-10-19 decision. Squash-merging.

@cristim
cristim merged commit 40fb137 into main Oct 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant