Skip to content

chore: prune monorepo-only config from golangci and pre-commit - #606

Merged
cristim merged 4 commits into
mainfrom
chore/2-prune-dead-config
Oct 20, 2026
Merged

cristim merged 4 commits into
mainfrom
chore/2-prune-dead-config

Conversation

@cristim

@cristim cristim commented Oct 20, 2026

Copy link
Copy Markdown
Member

Item 3 of #2: prune monorepo-only entries from .golangci.yml and .pre-commit-config.yaml.

git ls-files returns 0 files for each of internal/*, cmd/*, frontend/*, terraform/*, iac/*, cloudformation/*, docker-compose*, *.tf, .tflint.hcl, *.sql, package.json. Removed:

  • golangci: exclusions for internal/testutil, internal/api (revive) and cmd/configure_* (noctx); the internal/* alternatives of the misspell path (kept pkg/ladder/(store|types_test).go, which carry the "cancelled" status values).
  • pre-commit: terraform_fmt/validate/tflint, the migration-conflict check, permissions-codegen, the frontend build and jest pre-push hooks, trivy's terraform skip-dir, and the non-existent dirs in the check-yaml exclude.

Evidence: golangci-lint in all five modules reports 0 issues before and after. pre-commit run --all-files is identical apart from the five removed hooks, all of which were "no files to check".

#601 (the workflow item) is not touched.

Part of #2

🤖 Generated with Claude Code

Remove entries whose paths or tools do not exist in this repo
(git ls-files returns 0 for each of: internal/*, cmd/*, frontend/*,
terraform/*, iac/*, cloudformation/*, docker-compose*, *.tf, .tflint.hcl,
*.sql, package.json):

- .golangci.yml: errcheck/gosec exclusion for internal/testutil, revive
  exclusion for internal/api, noctx exclusion for cmd/configure_*, and the
  internal/* alternatives of the misspell path (kept pkg/ladder, which has
  the "cancelled" status values).
- .pre-commit-config.yaml: terraform_fmt/validate/tflint, the migration
  conflict check, permissions-codegen, the frontend build and jest
  pre-push hooks, the terraform skip-dirs of trivy, and the non-existent
  dirs in the check-yaml exclude.

golangci-lint in all five modules: 0 issues before and after.
pre-commit run --all-files: identical results apart from the five removed
hooks, which were all "no files to check".

Part of #2

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 2 billable files and costs up to $0.50.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 6 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 88 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: LeanerCloud/cloud-commitments-go/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 4f9ce29a-d1a3-4992-8c7f-5f602e173243
📥 Commits

Reviewing files that changed from the base of the PR and between ca53ccb and 1dcb069.

📒 Files selected for processing: 2
  • .golangci.yml
  • .pre-commit-config.yaml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@cristim

cristim commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

Merge gate verdict (claude-cc-libs)

Every gate holds at head 1dcb069:

  • Two independent reviews approve the reviewed head 709a431. The branch was then updated from main, and the PR diff is byte-identical to the reviewed diff (compared mechanically).
  • CI is green on 1dcb069, which is the reviewed change on top of current main.
  • 0 unresolved threads; MERGEABLE/CLEAN.

CodeRabbit is waived as a merge gate under the 2026-10-19 decision. Squash-merging.

@cristim
cristim merged commit ab13394 into main Oct 20, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant