Repository navigation
chore: prune monorepo-only config from golangci and pre-commit - #606
Merged
Merged
Conversation
Remove entries whose paths or tools do not exist in this repo (git ls-files returns 0 for each of: internal/*, cmd/*, frontend/*, terraform/*, iac/*, cloudformation/*, docker-compose*, *.tf, .tflint.hcl, *.sql, package.json): - .golangci.yml: errcheck/gosec exclusion for internal/testutil, revive exclusion for internal/api, noctx exclusion for cmd/configure_*, and the internal/* alternatives of the misspell path (kept pkg/ladder, which has the "cancelled" status values). - .pre-commit-config.yaml: terraform_fmt/validate/tflint, the migration conflict check, permissions-codegen, the frontend build and jest pre-push hooks, the terraform skip-dirs of trivy, and the non-existent dirs in the check-yaml exclude. golangci-lint in all five modules: 0 issues before and after. pre-commit run --all-files: identical results apart from the five removed hooks, which were all "no files to check". Part of #2 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 6 minutes for your next included review. View limit details
Comment |
Member
Author
Merge gate verdict (claude-cc-libs)Every gate holds at head 1dcb069:
CodeRabbit is waived as a merge gate under the 2026-10-19 decision. Squash-merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item 3 of #2: prune monorepo-only entries from
.golangci.ymland.pre-commit-config.yaml.git ls-filesreturns 0 files for each ofinternal/*,cmd/*,frontend/*,terraform/*,iac/*,cloudformation/*,docker-compose*,*.tf,.tflint.hcl,*.sql,package.json. Removed:internal/testutil,internal/api(revive) andcmd/configure_*(noctx); theinternal/*alternatives of the misspell path (keptpkg/ladder/(store|types_test).go, which carry the "cancelled" status values).Evidence: golangci-lint in all five modules reports 0 issues before and after.
pre-commit run --all-filesis identical apart from the five removed hooks, all of which were "no files to check".#601 (the workflow item) is not touched.
Part of #2
🤖 Generated with Claude Code