Skip to content

refactor(cmd): split configure_gcp.go by concern #2291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristim merged 8 commits into from
Oct 20, 2026
Merged

refactor(cmd): split configure_gcp.go by concern #2291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
62f1a42
refactor(cmd): split GCP SDK helpers out of configure_gcp.go
cristim Oct 20, 2026
499f336
refactor(cmd): split GCP IAM role helpers out of configure_gcp.go
cristim Oct 20, 2026
0c5b1bd
refactor(cmd): split GCP setup flow out of configure_gcp.go
cristim Oct 20, 2026
cedb195
refactor(cmd): split GCP service-account steps out of configure_gcp.go
cristim Oct 20, 2026
4bda99e
refactor(cmd): split GCP grant and key steps out of configure_gcp.go
cristim Oct 20, 2026
e77d8b2
refactor(cmd): split GCP command prompt helpers out of configure_gcp.go
cristim Oct 20, 2026
831d7a0
fix(lint): cover split configure files in the noctx exclusion
cristim Oct 20, 2026
85ad31c
Merge branch 'main' into refactor/1834-split-gcp
cristim Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ linters:
# Suppressed per-file rather than per-line so #nosec G204 can lead the comment.
- linters:
- noctx
path: (cmd/configure_gcp|cmd/configure_azure)\.go
path: cmd/configure_(gcp|azure)(_exec|_setup)?\.go
# noctx: http.Get and net.Listen in test helpers appropriately use the
# background context; threading a test context through every helper would
# add noise without improving test correctness.
Expand Down
Loading
Loading