Skip to content

chore(deps): bump cloud-commitments-go to dcb5ba0 - #2284

Merged
cristim merged 1 commit into
mainfrom
chore/bump-cloud-commitments-go
Oct 20, 2026
Merged

cristim merged 1 commit into
mainfrom
chore/bump-cloud-commitments-go

Conversation

@cristim

@cristim cristim commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Bumps the four cloud-commitments-go modules (pkg, providers/aws, providers/azure, providers/gcp) from cfe8ac29 to go main dcb5ba0. This unblocks cli#2181 (needs go#535's RI account scope) and cli#2214 (needs go#534's RederiveFamilyCoverage).

Only the 4 module lines and go.sum change, and no cli code changes were needed.

User-visible library changes it brings:

  • go#535: RI recommendations accept an account scope (the cli flag follows in feat(ri): consider PAYER account scope for RI recommendations #2181).
  • go#550: the Azure PurchaseCommitment guards, error messages and display names are aligned across services. Managed Redis and Synapse reservation names now use the standard generated format.
  • go#539: Azure holds the shared concurrency slot per outbound call instead of per service sweep.
  • The rest is internal: the shared Azure purchase helper (go#9) and test parallelization (go#108).

Build, vet, go test -count=1 ./..., lint and the secrets check pass.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • AWS Reserved Instance recommendations now support configurable account scope.
    • Added support for recalculating family coverage after sizing counts change.
  • Improvements

    • Azure reservation purchases now provide more consistent validation, error handling, and display names.
    • Reservation purchase operations now manage concurrency independently for each call.
  • Documentation

    • Updated the changelog with the latest cloud commitments improvements.

Bump pkg and the aws, azure and gcp providers to go main, bringing the
AWS RI account scope option, exported RederiveFamilyCoverage, and the
Azure purchase guard, display name and concurrency fixes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: LeanerCloud/cloud-commitments-cli/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: aae46abc-1a10-45c1-9288-1916af9bd96d
📥 Commits

Reviewing files that changed from the base of the PR and between f7baf8e and 7dcce60.

⛔ Files ignored due to path filters: 1
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing: 2
  • CHANGELOG.md
  • go.mod

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

📝 Walkthrough

The pull request updates four cloud-commitments-go dependencies to a newer revision. The changelog records Azure reservation purchase updates, configurable AWS recommendation account scope, and the exported RederiveFamilyCoverage function.

Changes: Commitments dependency update

Layer / File(s) Summary
Update commitments dependency and changelog
go.mod, CHANGELOG.md
Four cloud-commitments-go dependencies use the newer revision. The changelog records shared Azure purchase helper updates, configurable AWS recommendation account scope, and the exported RederiveFamilyCoverage function.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 7dcce

No actionable merge-blocking risk is established.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: updating the cloud-commitments-go dependency to commit dcb5ba0.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@cristim

cristim commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

Review Y (independent, claude-cc-libs-rev-Y): APPROVE at 7dcce60

  • GOWORK=off go mod verify: all modules verified, and go mod tidy is a no-op.
  • 29 lines (CHANGELOG +5, go.mod 4/4, go.sum 8/8). All four modules move consistently from cfe8ac29cee7 to dcb5ba0b4061.
  • go test -race -count=1 ./cmd/... passes with no race reports.
  • golangci-lint v2.10.1 reports 0 issues.

@cristim

cristim commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

Review X (independent, claude-cc-libs-rev-X): APPROVE at 7dcce60

  1. Scope. Only CHANGELOG, go.mod (4 lines) and go.sum change. The pseudo-version v0.0.0-20261020034927-dcb5ba0b4061 matches dcb5ba0's commit time (03:49:27Z) and hash.
  2. What the bump brings in.
    • go#550: the new guards, the synapse error text and BuildDisplayName names. The old names and texts appear nowhere in the cli. The only purchase call site (multi_service_helpers.go:296) passes errors through, and the purchase tests mock PurchaseCommitment.
    • go#539: the cli never installs a semaphore, so the slot calls are no-ops.
    • go#535: the cli sets only SPAccountScope (multi_service_helpers.go:486), so the RI scope stays LINKED.
    • go#534: not referenced yet.
  3. Tests. Build, vet and go test -count=1 ./... pass.
  4. CHANGELOG. Accurate; it summarizes the go#550 guard and message changes broadly.

@cristim

cristim commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

Merge gate verdict (claude-cc-libs)

Every gate holds at head 7dcce60:

  • Two independent reviews approve the reviewed head 7dcce60. The branch was then updated from main, and the PR diff is byte-identical to the reviewed diff (compared mechanically).
  • CI is green on 7dcce60, which is the reviewed change on top of current main.
  • 0 unresolved threads; MERGEABLE/CLEAN.

CodeRabbit is waived as a merge gate under the 2026-10-19 decision. Squash-merging.

@cristim
cristim merged commit a872fc6 into main Oct 20, 2026
12 checks passed
@cristim
cristim deleted the chore/bump-cloud-commitments-go branch October 20, 2026 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant