Skip to content

test(providers/azure): reuse shared mocks in synapse/managedredis #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristim merged 1 commit into from
Jul 21, 2026
Merged

test(providers/azure): reuse shared mocks in synapse/managedredis #1470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 39 additions & 54 deletions providers/azure/services/managedredis/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,23 +77,8 @@ func (m *mockRedisPager) NextPage(_ context.Context) (armredis.ClientListBySubsc
return p, nil
}

type mockHTTPClient struct{ mock.Mock }

func (m *mockHTTPClient) Do(req *http.Request) (*http.Response, error) {
args := m.Called(req)
if args.Get(0) == nil {
return nil, args.Error(1)
}
return args.Get(0).(*http.Response), args.Error(1)
}

func fakeHTTPResp(status int, body string) *http.Response {
return &http.Response{
StatusCode: status,
Body: io.NopCloser(bytes.NewBufferString(body)),
Header: make(http.Header),
}
}
// The mock HTTP client and response helper live in the shared
// providers/azure/mocks package (mocks.MockHTTPClient, mocks.CreateMockHTTPResponse).

func samplePricingJSON() string {
return `{
Expand Down Expand Up @@ -191,7 +176,7 @@ func TestNewClientWithHTTP_NilFallbackIsHardened(t *testing.T) {
// returns an error rather than fabricating a price from a hardcoded multiplier
// (issue #1020 H4). Pre-fix this would have returned a fabricated price silently.
func TestGetOfferingDetails_NoReservationPricing(t *testing.T) {
h := &mockHTTPClient{}
h := &mocks.MockHTTPClient{}
t.Cleanup(func() { h.AssertExpectations(t) })
onDemandOnly := `{
"Items": [
Expand All @@ -209,7 +194,7 @@ func TestGetOfferingDetails_NoReservationPricing(t *testing.T) {
"NextPageLink": "",
"Count": 1
}`
h.On("Do", mock.Anything).Return(fakeHTTPResp(http.StatusOK, onDemandOnly), nil)
h.On("Do", mock.Anything).Return(mocks.CreateMockHTTPResponse(http.StatusOK, onDemandOnly), nil)
c := NewClientWithHTTP(nil, "sub", "eastus", h)
_, err := c.GetOfferingDetails(context.Background(), common.Recommendation{
ResourceType: "Premium_P1", Term: "1yr",
Expand All @@ -219,7 +204,7 @@ func TestGetOfferingDetails_NoReservationPricing(t *testing.T) {
}

func TestNewClientWithHTTP(t *testing.T) {
h := &mockHTTPClient{}
h := &mocks.MockHTTPClient{}
c := NewClientWithHTTP(nil, "sub-123", "eastus", h)
require.NotNil(t, c)
assert.Equal(t, h, c.httpClient)
Expand Down Expand Up @@ -445,9 +430,9 @@ func TestGetExistingCommitments_PagerError(t *testing.T) {
// -- GetOfferingDetails --

func TestGetOfferingDetails_1yr(t *testing.T) {
h := &mockHTTPClient{}
h := &mocks.MockHTTPClient{}
t.Cleanup(func() { h.AssertExpectations(t) })
h.On("Do", mock.Anything).Return(fakeHTTPResp(http.StatusOK, samplePricingJSON()), nil)
h.On("Do", mock.Anything).Return(mocks.CreateMockHTTPResponse(http.StatusOK, samplePricingJSON()), nil)
c := NewClientWithHTTP(nil, "sub", "eastus", h)
details, err := c.GetOfferingDetails(context.Background(), common.Recommendation{
ResourceType: "Premium_P1", Term: "1yr", PaymentOption: "upfront",
Expand All @@ -461,9 +446,9 @@ func TestGetOfferingDetails_1yr(t *testing.T) {
}

func TestGetOfferingDetails_3yr(t *testing.T) {
h := &mockHTTPClient{}
h := &mocks.MockHTTPClient{}
t.Cleanup(func() { h.AssertExpectations(t) })
h.On("Do", mock.Anything).Return(fakeHTTPResp(http.StatusOK, samplePricingJSON()), nil)
h.On("Do", mock.Anything).Return(mocks.CreateMockHTTPResponse(http.StatusOK, samplePricingJSON()), nil)
c := NewClientWithHTTP(nil, "sub", "eastus", h)
details, err := c.GetOfferingDetails(context.Background(), common.Recommendation{
ResourceType: "Premium_P1", Term: "3yr", PaymentOption: "monthly",
Expand All @@ -479,9 +464,9 @@ func TestGetOfferingDetails_3yr(t *testing.T) {
}

func TestGetOfferingDetails_NoUpfront(t *testing.T) {
h := &mockHTTPClient{}
h := &mocks.MockHTTPClient{}
t.Cleanup(func() { h.AssertExpectations(t) })
h.On("Do", mock.Anything).Return(fakeHTTPResp(http.StatusOK, samplePricingJSON()), nil)
h.On("Do", mock.Anything).Return(mocks.CreateMockHTTPResponse(http.StatusOK, samplePricingJSON()), nil)
c := NewClientWithHTTP(nil, "sub", "eastus", h)
details, err := c.GetOfferingDetails(context.Background(), common.Recommendation{
ResourceType: "Premium_P1", Term: "1yr", PaymentOption: "no-upfront",
Expand All @@ -492,19 +477,19 @@ func TestGetOfferingDetails_NoUpfront(t *testing.T) {
}

func TestGetOfferingDetails_APIError(t *testing.T) {
h := &mockHTTPClient{}
h := &mocks.MockHTTPClient{}
t.Cleanup(func() { h.AssertExpectations(t) })
h.On("Do", mock.Anything).Return(fakeHTTPResp(http.StatusInternalServerError, "Internal Server Error"), nil)
h.On("Do", mock.Anything).Return(mocks.CreateMockHTTPResponse(http.StatusInternalServerError, "Internal Server Error"), nil)
c := NewClientWithHTTP(nil, "sub", "eastus", h)
_, err := c.GetOfferingDetails(context.Background(), common.Recommendation{ResourceType: "Premium_P1", Term: "1yr"})
require.Error(t, err)
assert.Contains(t, err.Error(), "pricing API returned status 500")
}

func TestGetOfferingDetails_NoPricing(t *testing.T) {
h := &mockHTTPClient{}
h := &mocks.MockHTTPClient{}
t.Cleanup(func() { h.AssertExpectations(t) })
h.On("Do", mock.Anything).Return(fakeHTTPResp(http.StatusOK, `{"Items": []}`), nil)
h.On("Do", mock.Anything).Return(mocks.CreateMockHTTPResponse(http.StatusOK, `{"Items": []}`), nil)
c := NewClientWithHTTP(nil, "sub", "eastus", h)
_, err := c.GetOfferingDetails(context.Background(), common.Recommendation{ResourceType: "Premium_P1", Term: "1yr"})
require.Error(t, err)
Expand Down Expand Up @@ -548,9 +533,9 @@ func TestGetOfferingDetails_Paginated(t *testing.T) {
"NextPageLink": "",
"Count": 1
}`
h := &mockHTTPClient{}
h.On("Do", mock.Anything).Return(fakeHTTPResp(http.StatusOK, page1), nil).Once()
h.On("Do", mock.Anything).Return(fakeHTTPResp(http.StatusOK, page2), nil).Once()
h := &mocks.MockHTTPClient{}
h.On("Do", mock.Anything).Return(mocks.CreateMockHTTPResponse(http.StatusOK, page1), nil).Once()
h.On("Do", mock.Anything).Return(mocks.CreateMockHTTPResponse(http.StatusOK, page2), nil).Once()
c := NewClientWithHTTP(nil, "sub", "eastus", h)
details, err := c.GetOfferingDetails(context.Background(), common.Recommendation{
ResourceType: "Premium_P1", Term: "1yr", PaymentOption: "upfront",
Expand All @@ -570,14 +555,14 @@ func calcPriceRespJSON(orderID string) string {
}

func TestPurchaseCommitment_Success(t *testing.T) {
h := &mockHTTPClient{}
h := &mocks.MockHTTPClient{}
t.Cleanup(func() { h.AssertExpectations(t) })
h.On("Do", mock.MatchedBy(func(r *http.Request) bool {
return r.URL.Path == "/providers/Microsoft.Capacity/calculatePrice"
})).Return(fakeHTTPResp(http.StatusOK, calcPriceRespJSON("mr-order-001")), nil).Once()
})).Return(mocks.CreateMockHTTPResponse(http.StatusOK, calcPriceRespJSON("mr-order-001")), nil).Once()
h.On("Do", mock.MatchedBy(func(r *http.Request) bool {
return r.URL.Path == "/providers/Microsoft.Capacity/reservationOrders/mr-order-001/purchase"
})).Return(fakeHTTPResp(http.StatusOK, `{}`), nil).Once()
})).Return(mocks.CreateMockHTTPResponse(http.StatusOK, `{}`), nil).Once()
cred := &mockTokenCredential{token: "tok"}
c := NewClientWithHTTP(cred, "sub", "eastus", h)
result, err := c.PurchaseCommitment(context.Background(), common.Recommendation{
Expand All @@ -590,14 +575,14 @@ func TestPurchaseCommitment_Success(t *testing.T) {
}

func TestPurchaseCommitment_3yr(t *testing.T) {
h := &mockHTTPClient{}
h := &mocks.MockHTTPClient{}
t.Cleanup(func() { h.AssertExpectations(t) })
h.On("Do", mock.MatchedBy(func(r *http.Request) bool {
return r.URL.Path == "/providers/Microsoft.Capacity/calculatePrice"
})).Return(fakeHTTPResp(http.StatusOK, calcPriceRespJSON("mr-order-3yr")), nil).Once()
})).Return(mocks.CreateMockHTTPResponse(http.StatusOK, calcPriceRespJSON("mr-order-3yr")), nil).Once()
h.On("Do", mock.MatchedBy(func(r *http.Request) bool {
return r.URL.Path == "/providers/Microsoft.Capacity/reservationOrders/mr-order-3yr/purchase"
})).Return(fakeHTTPResp(http.StatusCreated, `{}`), nil).Once()
})).Return(mocks.CreateMockHTTPResponse(http.StatusCreated, `{}`), nil).Once()
cred := &mockTokenCredential{token: "tok"}
c := NewClientWithHTTP(cred, "sub", "eastus", h)
result, err := c.PurchaseCommitment(context.Background(), common.Recommendation{
Expand All @@ -609,14 +594,14 @@ func TestPurchaseCommitment_3yr(t *testing.T) {
}

func TestPurchaseCommitment_Accepted(t *testing.T) {
h := &mockHTTPClient{}
h := &mocks.MockHTTPClient{}
t.Cleanup(func() { h.AssertExpectations(t) })
h.On("Do", mock.MatchedBy(func(r *http.Request) bool {
return r.URL.Path == "/providers/Microsoft.Capacity/calculatePrice"
})).Return(fakeHTTPResp(http.StatusOK, calcPriceRespJSON("mr-order-202")), nil).Once()
})).Return(mocks.CreateMockHTTPResponse(http.StatusOK, calcPriceRespJSON("mr-order-202")), nil).Once()
h.On("Do", mock.MatchedBy(func(r *http.Request) bool {
return r.URL.Path == "/providers/Microsoft.Capacity/reservationOrders/mr-order-202/purchase"
})).Return(fakeHTTPResp(http.StatusAccepted, `{}`), nil).Once()
})).Return(mocks.CreateMockHTTPResponse(http.StatusAccepted, `{}`), nil).Once()
cred := &mockTokenCredential{token: "tok"}
c := NewClientWithHTTP(cred, "sub", "eastus", h)
result, err := c.PurchaseCommitment(context.Background(), common.Recommendation{
Expand All @@ -627,7 +612,7 @@ func TestPurchaseCommitment_Accepted(t *testing.T) {
}

func TestPurchaseCommitment_TokenError(t *testing.T) {
h := &mockHTTPClient{}
h := &mocks.MockHTTPClient{}
t.Cleanup(func() { h.AssertExpectations(t) })
cred := &mockTokenCredential{err: errors.New("token error")}
c := NewClientWithHTTP(cred, "sub", "eastus", h)
Expand All @@ -640,7 +625,7 @@ func TestPurchaseCommitment_TokenError(t *testing.T) {
}

func TestPurchaseCommitment_HTTPError(t *testing.T) {
h := &mockHTTPClient{}
h := &mocks.MockHTTPClient{}
t.Cleanup(func() { h.AssertExpectations(t) })
h.On("Do", mock.MatchedBy(func(r *http.Request) bool {
return r.URL.Path == "/providers/Microsoft.Capacity/calculatePrice"
Expand All @@ -656,14 +641,14 @@ func TestPurchaseCommitment_HTTPError(t *testing.T) {
}

func TestPurchaseCommitment_BadStatus(t *testing.T) {
h := &mockHTTPClient{}
h := &mocks.MockHTTPClient{}
t.Cleanup(func() { h.AssertExpectations(t) })
h.On("Do", mock.MatchedBy(func(r *http.Request) bool {
return r.URL.Path == "/providers/Microsoft.Capacity/calculatePrice"
})).Return(fakeHTTPResp(http.StatusOK, calcPriceRespJSON("mr-order-bad")), nil).Once()
})).Return(mocks.CreateMockHTTPResponse(http.StatusOK, calcPriceRespJSON("mr-order-bad")), nil).Once()
h.On("Do", mock.MatchedBy(func(r *http.Request) bool {
return r.URL.Path == "/providers/Microsoft.Capacity/reservationOrders/mr-order-bad/purchase"
})).Return(fakeHTTPResp(http.StatusBadRequest, `{"error":"bad"}`), nil).Once()
})).Return(mocks.CreateMockHTTPResponse(http.StatusBadRequest, `{"error":"bad"}`), nil).Once()
cred := &mockTokenCredential{token: "tok"}
c := NewClientWithHTTP(cred, "sub", "eastus", h)
result, err := c.PurchaseCommitment(context.Background(), common.Recommendation{
Expand All @@ -675,7 +660,7 @@ func TestPurchaseCommitment_BadStatus(t *testing.T) {
}

func TestPurchaseCommitment_InvalidTerm(t *testing.T) {
h := &mockHTTPClient{}
h := &mocks.MockHTTPClient{}
t.Cleanup(func() { h.AssertExpectations(t) })
c := NewClientWithHTTP(nil, "sub", "eastus", h)
result, err := c.PurchaseCommitment(context.Background(), common.Recommendation{
Expand All @@ -693,7 +678,7 @@ func TestPurchaseCommitment_InvalidTerm(t *testing.T) {
// signal CUDly controls -- proceeding without it would allow a re-driven
// purchase to create a duplicate reservation.
func TestPurchaseCommitment_RequiresSource(t *testing.T) {
h := &mockHTTPClient{}
h := &mocks.MockHTTPClient{}
t.Cleanup(func() { h.AssertExpectations(t) })
cred := &mockTokenCredential{token: "tok"}
c := NewClientWithHTTP(cred, "sub", "eastus", h)
Expand All @@ -707,7 +692,7 @@ func TestPurchaseCommitment_RequiresSource(t *testing.T) {
}

func TestGetOfferingDetails_InvalidTerm(t *testing.T) {
h := &mockHTTPClient{}
h := &mocks.MockHTTPClient{}
t.Cleanup(func() { h.AssertExpectations(t) })
c := NewClientWithHTTP(nil, "sub", "eastus", h)
_, err := c.GetOfferingDetails(context.Background(), common.Recommendation{
Expand Down Expand Up @@ -803,14 +788,14 @@ func TestPurchaseCommitment_TagInjection(t *testing.T) {
const orderID = "mr-tag-test-order"
const source = "cudly-web"

h := &mockHTTPClient{}
h := &mocks.MockHTTPClient{}
t.Cleanup(func() { h.AssertExpectations(t) })
cred := &mockTokenCredential{token: "tok"}
c := NewClientWithHTTP(cred, "sub", "eastus", h)

h.On("Do", mock.MatchedBy(func(r *http.Request) bool {
return r.URL.Path == "/providers/Microsoft.Capacity/calculatePrice"
})).Return(fakeHTTPResp(http.StatusOK, calcPriceRespJSON(orderID)), nil).Once()
})).Return(mocks.CreateMockHTTPResponse(http.StatusOK, calcPriceRespJSON(orderID)), nil).Once()

var capturedBody []byte
h.On("Do", mock.MatchedBy(func(r *http.Request) bool {
Expand All @@ -820,7 +805,7 @@ func TestPurchaseCommitment_TagInjection(t *testing.T) {
capturedBody, _ = io.ReadAll(r.Body)
r.Body = io.NopCloser(bytes.NewReader(capturedBody))
return true
})).Return(fakeHTTPResp(http.StatusOK, `{}`), nil).Once()
})).Return(mocks.CreateMockHTTPResponse(http.StatusOK, `{}`), nil).Once()

result, err := c.PurchaseCommitment(context.Background(), common.Recommendation{
ResourceType: "Premium_P1", Term: "1yr", Count: 1, CommitmentCost: 500.0,
Expand All @@ -841,7 +826,7 @@ func TestPurchaseCommitment_TagInjection(t *testing.T) {
// this guard a zero-quantity purchase would reach the Azure API and produce a
// confusing 400.
func TestPurchaseCommitment_ZeroCountRejected(t *testing.T) {
h := &mockHTTPClient{}
h := &mocks.MockHTTPClient{}
t.Cleanup(func() { h.AssertExpectations(t) })
cred := &mockTokenCredential{token: "tok"}
c := NewClientWithHTTP(cred, "sub", "eastus", h)
Expand Down
Loading
Loading