Skip to content

test(providers/azure): make IsConfigured guards deterministic #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristim merged 1 commit into from
Jul 20, 2026
Merged

test(providers/azure): make IsConfigured guards deterministic #1468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 39 additions & 19 deletions providers/azure/provider_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,14 +300,20 @@ func TestAzureProvider_IsConfigured(t *testing.T) {
}

func TestAzureProvider_GetCredentials_NotConfigured(t *testing.T) {
// Test GetCredentials when Azure is not configured
// Test GetCredentials when Azure is not configured. Inject a mock
// credential provider that fails so IsConfigured() deterministically
// returns false, instead of falling through to the real
// DefaultAzureCredential lookup.
p := &AzureProvider{}
// If IsConfigured returns false, GetCredentials should return error
if !p.IsConfigured() {
_, err := p.GetCredentials()
assert.Error(t, err)
assert.Contains(t, err.Error(), "azure provider is not configured")
}
p.SetCredentialProvider(&mockCredentialProvider{
cred: nil,
err: errors.New("no credentials"),
})
require.False(t, p.IsConfigured())

_, err := p.GetCredentials()
assert.Error(t, err)
assert.Contains(t, err.Error(), "azure provider is not configured")
}

func TestAzureProvider_ValidateCredentials(t *testing.T) {
Expand Down Expand Up @@ -375,13 +381,20 @@ func TestAzureProvider_ValidateCredentials(t *testing.T) {
}

func TestAzureProvider_GetServiceClient_NotConfigured(t *testing.T) {
// Test GetServiceClient when Azure is not configured
// Test GetServiceClient when Azure is not configured. Inject a mock
// credential provider that fails so IsConfigured() deterministically
// returns false, instead of falling through to the real
// DefaultAzureCredential lookup.
p := &AzureProvider{}
if !p.IsConfigured() {
_, err := p.GetServiceClient(context.Background(), common.ServiceCompute, "eastus")
assert.Error(t, err)
assert.Contains(t, err.Error(), "azure provider is not configured")
}
p.SetCredentialProvider(&mockCredentialProvider{
cred: nil,
err: errors.New("no credentials"),
})
require.False(t, p.IsConfigured())

_, err := p.GetServiceClient(context.Background(), common.ServiceCompute, "eastus")
assert.Error(t, err)
assert.Contains(t, err.Error(), "azure provider is not configured")
}

func TestAzureProvider_GetServiceClient_UnsupportedService(t *testing.T) {
Expand Down Expand Up @@ -429,13 +442,20 @@ func TestAzureProvider_GetServiceClient_AllServiceTypes(t *testing.T) {
}

func TestAzureProvider_GetRecommendationsClient_NotConfigured(t *testing.T) {
// Test GetRecommendationsClient when Azure is not configured
// Test GetRecommendationsClient when Azure is not configured. Inject a
// mock credential provider that fails so IsConfigured() deterministically
// returns false, instead of falling through to the real
// DefaultAzureCredential lookup.
p := &AzureProvider{}
if !p.IsConfigured() {
_, err := p.GetRecommendationsClient(context.Background())
assert.Error(t, err)
assert.Contains(t, err.Error(), "azure provider is not configured")
}
p.SetCredentialProvider(&mockCredentialProvider{
cred: nil,
err: errors.New("no credentials"),
})
require.False(t, p.IsConfigured())

_, err := p.GetRecommendationsClient(context.Background())
assert.Error(t, err)
assert.Contains(t, err.Error(), "azure provider is not configured")
}

func TestAzureProvider_GetRecommendationsClient(t *testing.T) {
Expand Down
Loading