[cristim]

Root cause

Service.CreateAPIKeyAPI in internal/auth/service_apikeys_api.go decoded the incoming request using a direct Go type assertion:

createReq, ok := req.(APICreateAPIKeyRequest)
if !ok {
    return nil, fmt.Errorf("invalid request type")
}

The HTTP handler (internal/api) unmarshals the JSON request body into api.CreateAPIKeyRequest, which is a distinct Go type in a different package. Even though both types carry identical json field tags (name, expires_at, permissions), Go's type system is nominal: the assertion req.(auth.APICreateAPIKeyRequest) always evaluates to false. Every call to POST /api/api-keys therefore returned "invalid request type", which bubbled up as a 500 "Failed to create API key: Internal server error".

The mock test (TestHandler_createAPIKey_Success) used mock.Anything so it never caught the type mismatch.

Fix

Replace the direct type assertion with a type switch:

• Fast path: if the caller already passes auth.APICreateAPIKeyRequest (existing service tests, direct internal callers), use it directly with zero overhead.
• Default path: JSON-encode the incoming value and decode it back into APICreateAPIKeyRequest. This accepts any struct with compatible json tags (api.CreateAPIKeyRequest, anonymous structs) without requiring cross-package imports.

Tests

• New: TestService_CreateAPIKeyAPI_CrossPackageType passes an anonymous struct (same json tags, different Go type) and asserts success. This test fails against the pre-fix code.
• Fixed: TestAuthServiceAdapter_CreateAPIKeyAPI in internal/server was missing GetUserByID and GetGroup mocks. The test silently passed before because the type assertion returned early before reaching those store calls. Now the full call chain executes and the mock setup is complete.

Closes

Closes #1440

[cristim]

@coderabbitai review

[coderabbitai]

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 11 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6fa90bc5-c71b-44d8-ae59-17d68cc1431e

📥 Commits

Reviewing files that changed from the base of the PR and between bef2d0e and 4c0883f.

📒 Files selected for processing (3)

• internal/auth/service_apikeys_api.go
• internal/auth/service_apikeys_api_test.go
• internal/server/adapter_test.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/1440-apikey-create-500

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[cristim]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[cristim]

@coderabbitai full review

[coderabbitai]

✅ Action performed

Full review finished.

---

You're currently rate limited under our Fair Usage Limits Policy. Your recent PR review activity is in the 95th percentile or higher among CodeRabbit users, so adaptive limits apply. Your next review will be available in 11 minutes.