Repository navigation
fix(ux): add CSS so usage-history sparkline is visible in Opportunities table - #1432
Conversation
…es table (#1417) The SVG inline sparkline rendered by renderUsageSparkline() had no matching CSS for .usage-sparkline or .usage-sparkline-cell, causing the SVG to be invisible or misaligned in some browsers. Add two rules to charts.css: - .usage-sparkline-cell: center-align with min-width so the column stays stable as data loads - .usage-sparkline: display:block with explicit color (--cudly-primary) so the SVG stroke/fill values inherited via currentColor are always visible regardless of ancestor color overrides Add integration tests verifying the SVG polyline appears in the rendered table HTML when a recommendation carries non-empty usage_history, and that the em-dash fallback is used when usage_history is null. Closes #1417
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 42 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Merged to main after independent review (SHIP) + all CI green. restore the Opportunities per-row usage sparkline (CSS currentColor resolution + cell sizing). |
Summary
.usage-sparkline-cellCSS rule (center-align,min-width: 4rem) and.usage-sparklineCSS rule (display: block,color: var(--cudly-primary)) tocharts.css; the missing rules meant the SVG'sstroke="currentColor"could inherit a color that was invisible or the SVG would be misaligned in the table cellrenderUsageSparkline()was already correct; only the stylesheet was missingusage_history, and the em-dash fallback is used whenusage_historyis nullCloses #1417