Skip to content

fix(terraform/aws): major-only RDS engine_version pin to stop downgrade failures #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristim merged 1 commit into from
Jul 16, 2026
Merged

fix(terraform/aws): major-only RDS engine_version pin to stop downgrade failures #1375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion terraform/environments/aws/dev.tfvars.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ fargate_max_capacity = 10

database_name = "cudly"
database_username = "cudly"
database_engine_version = "16.6"
database_engine_version = "16"
database_backup_retention_days = 7
database_deletion_protection = false # Allow deletion in dev
database_skip_final_snapshot = true # Skip in dev
Expand Down
2 changes: 1 addition & 1 deletion terraform/environments/aws/github-dev.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ fargate_max_capacity = 5

database_name = "cudly"
database_username = "cudly"
database_engine_version = "16.6"
database_engine_version = "16"
database_backup_retention_days = 7
database_deletion_protection = false
database_skip_final_snapshot = true
Expand Down
2 changes: 1 addition & 1 deletion terraform/environments/aws/github-prod.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ fargate_max_capacity = 20

database_name = "cudly"
database_username = "cudly"
database_engine_version = "16.6"
database_engine_version = "16"
database_backup_retention_days = 30
database_deletion_protection = true
database_skip_final_snapshot = false
Expand Down
2 changes: 1 addition & 1 deletion terraform/environments/aws/github-staging.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ fargate_max_capacity = 10

database_name = "cudly"
database_username = "cudly"
database_engine_version = "16.6"
database_engine_version = "16"
database_backup_retention_days = 14
database_deletion_protection = false
database_skip_final_snapshot = true
Expand Down
4 changes: 2 additions & 2 deletions terraform/environments/aws/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,9 @@ variable "database_username" {
}

variable "database_engine_version" {
description = "PostgreSQL version"
description = "PostgreSQL major engine version (major-only pin, e.g. \"16\"). The AWS provider resolves to the latest minor release and stores it in engine_version_actual, suppressing drift when RDS auto-upgrades the minor version. Pinning a full minor version (e.g. \"16.6\") causes downgrade failures if RDS auto-upgrades beyond it (incident: 2026-07-16, #1372)."
type = string
default = "16.6"
default = "16"
}

variable "database_instance_class" {
Expand Down
7 changes: 6 additions & 1 deletion terraform/modules/database/aws/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,12 @@ resource "aws_db_instance" "main" {
engine = "postgres"

engine_version = var.engine_version
instance_class = var.instance_class
# Major-only engine_version pin: the provider stores the real minor in
# engine_version_actual and suppresses diff on auto-minor upgrades.
# auto_minor_version_upgrade must be explicitly true so the intent is
# self-describing (incident: 2026-07-16, #1372).
auto_minor_version_upgrade = true
instance_class = var.instance_class

db_name = var.database_name
username = var.master_username
Expand Down
4 changes: 2 additions & 2 deletions terraform/modules/database/aws/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ variable "create_password" {
}

variable "engine_version" {
description = "PostgreSQL engine version"
description = "PostgreSQL major engine version (major-only pin, e.g. \"16\"). The AWS provider resolves to the latest minor release and stores it in engine_version_actual, suppressing drift when RDS auto-upgrades the minor version. Pinning a full minor version (e.g. \"16.6\") causes downgrade failures if RDS auto-upgrades beyond it (incident: 2026-07-16, #1372)."
type = string
default = "16.6"
default = "16"
}

variable "instance_class" {
Expand Down
Loading