docs(examples): replace dead size fields in component-showcase#39
Merged
Conversation
…component-showcase The legacy size field is silently ignored since the CSS rework; the schema-driven attribute validation (#33) surfaced 21 uses in this example as true-positive warnings. Converted to style.width/height (what the author always intended); validate is now warning-free and the geometry pass stays green.
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completeness-pass follow-up from the wave-1 chantier (#24): the attribute validation added in #33 flagged 21 true-positive uses of the silently-ignored legacy
sizefield incomponent-showcase.json. Converted tostyle.width/height;rustmotion validateis now warning-free on all shipped examples and geometry stays green.