fix(engine): honor start_at/end_at visibility windows and wire timeline steps#27
Merged
Merged
Conversation
start_at/end_at were silently ignored by the box pipeline (only Particle was gated, on a legacy path) and timeline was consumed nowhere. - BoxNode carries a PaintWindow built from as_timed(); paint_node skips the node and its subtree outside [start_at, end_at) while keeping its layout space (CSS visibility semantics — siblings don't jump) - timeline steps resolve as their animations with delay += step.at, merged after style.animation (new AnimationEffect::shift_delay; continuous effects without a delay concept are unaffected) - Caption gains flattened TimingConfig; Positioned gains timing, timeline and animation support; both join the timed/animatable dispatch (the last two components excluded from it) - skill rule timeline-sequencing.md rewritten for the new semantics
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5. Closes #6. Closes #7.
Goal: the timing schema stops lying —
start_at/end_atgate painting for every component,timelinesteps actually trigger animations, Caption/Positioned join the dispatch.BoxNodegains aPaintWindow(fromas_timed());paint_nodereturns early outside[start_at, end_at)— subtree included, no hits recorded — while the node keeps its layout space (CSSvisibilitysemantics, matching legacy counter behavior; siblings must not jump)timeline: [{at, animation[]}]resolves as the step's animations withdelay += at, merged afterstyle.animation(AnimationEffect::shift_delay; glow/wiggle/orbit/motion-blur have no delay concept and are documented no-ops)TimingConfig; Positioned getstiming+timeline+ animation support; both wired intoas_timed/as_animatabletimeline-sequencing.mdrewritten: start_at = visibility, animation delay = motion, timeline = grouped timed phasesTests: 3 new pixel-level regression tests (start_at hides before window, end_at hides after, timeline fade_in animates in its window) — written red first. 133 total, all green.
Verify:
cargo test --workspace✓ ·cargo fmt --check✓ · clippy 0 warnings ✓