test(components): serde round-trip coverage for every component variant and alias#26
Merged
Merged
Conversation
Adds three guards against the schema-drift class of bug (the container alias was silently lost by a bare rename to div): - round-trip: canonical serialization must re-deserialize identically - aliases: container->div, progress_bar->progress map to canonical tags - completeness: every type tag in the generated JSON schema must have a minimal corpus entry (16 components were missing; added, which also enrolls them in the existing paint smoke tests) Also untracks .claude/dev-methodology.local.md (personal prefs file committed by mistake in #25).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10.
Three new tests in the component smoke module:
container→divandprogress_bar→progressmust serialize to canonical tagstypetag in the schemars-generated schema must have a corpus entry — this found 16 components missing from the corpus (image, video, gif, caption, connector, avatar, avatar_group, arrow, comparison, dot_map, line, lottie, mockup, notification, pill_nav, tooltip); adding them also enrolls them in the existing paint smoke testsAlso untracks
.claude/dev-methodology.local.md(personal prefs committed by mistake in #25) and gitignores.claude/*.local.md.Verify:
cargo test --workspace→ 130 passed ·cargo fmt --check✓ · clippy 0 warnings