TE-13434: accept tags in smartui.json and surface tag warnings - #561
Open
shrinishLT wants to merge 5 commits into
Open
TE-13434: accept tags in smartui.json and surface tag warnings#561shrinishLT wants to merge 5 commits into
shrinishLT wants to merge 5 commits into
Conversation
…uild creation tags is an array of up to 10 unique non-empty strings of at most 50 characters, the dashboard's own limits, so the config fails loudly at the edge instead of DES dropping names silently. It rides the existing config payload to the rendering service, and upload-pdf sends it as a form field. Warnings returned by build creation are printed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JFAN4x1TwwoT9mHnqqn6Eh
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JFAN4x1TwwoT9mHnqqn6Eh
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JFAN4x1TwwoT9mHnqqn6Eh
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JFAN4x1TwwoT9mHnqqn6Eh
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JFAN4x1TwwoT9mHnqqn6Eh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI half of TE-13434 — RFC: LambdatestIncPrivate/internal-docs#2952. Needs LambdatestIncPrivate/smartui-rendering-service#1263 and LambdatestIncPrivate/dotlapse-event-service#2912 deployed first; until then the field is ignored downstream.
Before:
"tags": ["a"]insmartui.json→[smartui] Error: must NOT have additional properties.After:
tagsis accepted at the root of the config as an array of up to 50 unique, non-empty strings of at most 50 characters. Those are the SmartUI dashboard's own limits, so the schema refuses what the UI would refuse, with a message naming the rule, before any request is sent. Anything that still reaches DES invalid is refused there with a400, which already fails the build. Nothing else about the schema changes.Wiring:
ctx.config.tagsis populated, so the existingconfigpayload increateBuildcarries it to the rendering service with no wire change.upload-pdfappendstagsas a comma-separated form field.Base is
stage, matching how features land here. Compiles withtsup.🤖 Generated with Claude Code
https://claude.ai/code/session_01JFAN4x1TwwoT9mHnqqn6Eh