Skip to content

TE-12436: fix screenshot upload ECONNRESET for payloads over 2MB #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shrinishLT wants to merge 1 commit into
base: prod
Choose a base branch
from
+5 −1
Open

TE-12436: fix screenshot upload ECONNRESET for payloads over 2MB #500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/lib/httpClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,8 @@ export default class httpClient {
browserName = browserName === constants.SAFARI ? constants.WEBKIT : browserName;
const file = fs.readFileSync(ssPath);
const form = new FormData();
// form-data defaults maxDataSize to 2MB; disable to allow large screenshots
(form as any).maxDataSize = Infinity;
form.append('screenshot', file, { filename: `${ssName}.png`, contentType: 'image/png' });
form.append('browser', browserName);
form.append('viewport', viewport);
Expand All @@ -343,7 +345,9 @@ export default class httpClient {
method: 'POST',
headers: form.getHeaders(),
data: form,
timeout: 30000
timeout: 30000,
maxBodyLength: Infinity, // prevent axios from limiting the body size
maxContentLength: Infinity, // prevent axios from limiting the content size
})
.then(() => {
log.debug(`${ssName} for ${browserName} ${viewport} uploaded successfully`);
Expand Down