Remove CSP versions from headers and URLs#7487
Open
labkey-adam wants to merge 2 commits intorelease26.3-SNAPSHOTfrom
Open
Remove CSP versions from headers and URLs#7487labkey-adam wants to merge 2 commits intorelease26.3-SNAPSHOTfrom
labkey-adam wants to merge 2 commits intorelease26.3-SNAPSHOTfrom
Conversation
labkey-jeckels
approved these changes
Mar 14, 2026
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
I haven't had a chance to test this yet.
| * Extract the cspVersion parameter value from a comment in the CSP, if it exists. Otherwise, cspVersion is left as | ||
| * "Unknown". This value is reported as part of usage metrics and sent in reports. | ||
| */ | ||
| private void extractCspVersion(String s) |
Contributor
There was a problem hiding this comment.
Good candidate for a new, targeted unit test.
| } | ||
| catch (IllegalArgumentException e) | ||
| int start = idx + CSP_VERSION.length(); | ||
| int end = s.indexOf(" ", start); |
Contributor
There was a problem hiding this comment.
Are we guaranteed to always have a space afterwards? If that's the required convention, consider error logging if we don't.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
There's no need to send
cspVersionto the browser and back to the server. Mirrors what we did recently forlabkeyVersion.Related Pull Requests