Skip to content

Provisional Protein Sequences#1953

Open
labkey-alan wants to merge 2 commits intodevelopfrom
fb_provisional_ps
Open

Provisional Protein Sequences#1953
labkey-alan wants to merge 2 commits intodevelopfrom
fb_provisional_ps

Conversation

@labkey-alan
Copy link
Contributor

@labkey-alan labkey-alan commented Mar 11, 2026

Rationale

This PR updates the UnidentifiedPill to support provisional Protein Sequences in addition to Nucleotide Sequences.

Related Pull Requests

Changes

  • UnidentifiedPill: add support for provisional Protein Sequences
  • SchemaQuery.isEqual add optional arg to ignore view name
  • hasIdentifiedCol: use arg to ignore view name

@labkey-alan labkey-alan self-assigned this Mar 11, 2026
schemaQuery: SchemaQuery;
}

// TODO: take schemaQuery property and use that to determine the appropriate popover content
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO done?

() => (
<Popover id="unidentified-sequence-popover" placement="top" targetRef={targetRef}>
<div className="unidentified-sequence-popover">{EMPTY_SEQUENCE_WARNING}</div>
<div className="unidentified-sequence-popover">{message}</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add message to dependency array

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants