Skip to content

Update Array filter multi-value delimiter to ';' to match IN/NOT IN filter types #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XingY wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update Array filter multi-value delimiter to ';' to match IN/NOT IN filter types #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
### 1.45.X - 2026-X
- Update Array filter multi-value delimiter to ';' to match IN/NOT IN filter types to allow filter type conversion

### 1.45.0 - 2026-01-20
- Add Array filter types
- ARRAY_CONTAINS_ALL, ARRAY_CONTAINS_ANY, ARRAY_CONTAINS_EXACT, ARRAY_CONTAINS_NOT_EXACT, ARRAY_ISEMPTY, ARRAY_ISNOTEMPTY
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@labkey/api",
"version": "1.45.0",
"version": "1.45.1-fb-mvtc-convert.1",
"description": "JavaScript client API for LabKey Server",
"scripts": {
"build": "npm run build:dist && npm run build:docs",
Expand Down
10 changes: 5 additions & 5 deletions src/labkey/filter/Types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,32 +128,32 @@ export const Types: Record<string, IFilterType> = {
// These operators require a data value
//

ARRAY_CONTAINS_ALL: registerFilterType('Contains All', null, 'arraycontainsall', true, ',', 'Contains All Of'),
ARRAY_CONTAINS_ALL: registerFilterType('Contains All', null, 'arraycontainsall', true, ';', 'Contains All Of'),
ARRAY_CONTAINS_ANY: registerFilterType(
'Contains Any',
null,
'arraycontainsany',
true,
',',
';',
'Contains At Least One Of'
),
ARRAY_CONTAINS_EXACT: registerFilterType(
'Contains Exactly',
null,
'arraymatches',
true,
',',
';',
'Contains Exactly the Selected Values'
),
ARRAY_CONTAINS_NOT_EXACT: registerFilterType(
'Does Not Contain Exactly',
null,
'arraynotmatches',
true,
',',
';',
'Does Not Contains Exactly the Selected Values'
),
ARRAY_CONTAINS_NONE: registerFilterType('Contains None', null, 'arraycontainsnone', true, ',', 'Contains None Of'),
ARRAY_CONTAINS_NONE: registerFilterType('Contains None', null, 'arraycontainsnone', true, ';', 'Contains None Of'),

EQUAL,
DATE_EQUAL: registerFilterType(
Expand Down
10 changes: 5 additions & 5 deletions src/test/data/filter_types_snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"getMultiValueFilter": null,
"getMultiValueMaxOccurs": "undefined",
"getMultiValueMinOccurs": "undefined",
"getMultiValueSeparator": ",",
"getMultiValueSeparator": ";",
"getOpposite": null,
"getSingleValueFilter": "undefined",
"getURLParameterValue": "undefined",
Expand All @@ -24,7 +24,7 @@
"getMultiValueFilter": null,
"getMultiValueMaxOccurs": "undefined",
"getMultiValueMinOccurs": "undefined",
"getMultiValueSeparator": ",",
"getMultiValueSeparator": ";",
"getOpposite": null,
"getSingleValueFilter": "undefined",
"getURLParameterValue": "undefined",
Expand All @@ -41,7 +41,7 @@
"getMultiValueFilter": null,
"getMultiValueMaxOccurs": "undefined",
"getMultiValueMinOccurs": "undefined",
"getMultiValueSeparator": ",",
"getMultiValueSeparator": ";",
"getOpposite": null,
"getSingleValueFilter": "undefined",
"getURLParameterValue": "undefined",
Expand All @@ -58,7 +58,7 @@
"getMultiValueFilter": null,
"getMultiValueMaxOccurs": "undefined",
"getMultiValueMinOccurs": "undefined",
"getMultiValueSeparator": ",",
"getMultiValueSeparator": ";",
"getOpposite": null,
"getSingleValueFilter": "undefined",
"getURLParameterValue": "undefined",
Expand All @@ -75,7 +75,7 @@
"getMultiValueFilter": null,
"getMultiValueMaxOccurs": "undefined",
"getMultiValueMinOccurs": "undefined",
"getMultiValueSeparator": ",",
"getMultiValueSeparator": ";",
"getOpposite": null,
"getSingleValueFilter": "undefined",
"getURLParameterValue": "undefined",
Expand Down