Skip to content

ROCm7.14 build - #111

Open
michaelmckinsey1 wants to merge 4 commits into
mainfrom
rocm714
Open

michaelmckinsey1 wants to merge 4 commits into
mainfrom
rocm714

Conversation

@michaelmckinsey1

Copy link
Copy Markdown
Collaborator

No description provided.

@michaelmckinsey1 michaelmckinsey1 self-assigned this Nov 12, 2026
Comment thread pyproject.toml
Comment on lines -79 to -88
cuda = [
"torch==2.12.0+cu132",
"mpi4py==4.1.1",
]
rocm = [
"torch==2.12.0+rocm7.2",
"torchaudio==2.11.0+rocm7.2",
"torchvision==0.27.0+rocm7.2",
"mpi4py==4.1.1+mpich.9.1.0",
]

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deciding to specify these requirements in the scripts instead of here

@michaelmckinsey1 michaelmckinsey1 Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is required for triton>=3.9

Comment thread scripts/install-tuolumne.sh Outdated
python -m pip install --no-cache-dir --no-binary=mpi4py 'mpi4py==4.1.2'

# ScaFFold's base dependencies and PyTorch's non-ROCm Python dependencies
python -m pip install -e '.[torch]'

@michaelmckinsey1 michaelmckinsey1 Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[torch] dependencies being added is because we install torch without dependencies earlier in this script - we install torch without the rocm dependencies because we can provide the necessary rocm libraries on the system via rocm/7.14.

installing with dependencies would require providing links to
repo.amd.com/rocm for each dep since these are not vendored by pytorch e.g.

pip install -e .[rocm] --find-links https://download.pytorch.org/whl/torch/  --find-links https://repo.amd.com/rocm/whl-multi-arch/torchaudio/ \
    --find-links https://repo.amd.com/rocm/whl-multi-arch/torchvision/ --find-links https://download.pytorch.org/whl/triton-rocm/ \
    --find-links https://repo.amd.com/rocm/whl-multi-arch/rocm/ --find-links https://repo.amd.com/rocm/whl-multi-arch/rocm-sdk-core/ \
    --find-links https://repo.amd.com/rocm/whl-multi-arch/rocm-sdk-libraries/ --find-links https://repo.amd.com/rocm/whl-multi-arch/amd-torch-device-gfx942/ \
    --find-links https://repo.amd.com/rocm/whl-multi-arch/amd-torchvision-device-gfx942/ --find-links https://repo.amd.com/rocm/whl-multi-arch/rocm-sdk-device-gfx942/ 2>&1 | tee install.log

# ScaFFold's base dependencies and PyTorch's non-ROCm Python dependencies
python -m pip install -e '.[torch]'

python -m pip install --no-deps "distconv @ git+https://github.com/LBANN/DistConv.git@084b20a"

@michaelmckinsey1 michaelmckinsey1 Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

distconv must be installed --no-deps, because it's single dep is torch, which will uninstall our existing torch, because pip will see the rocm library is not present (we are telling pip --no-deps because we are saying rocm will be provided by rocm/7.14 module)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant