Repository navigation
pacectl: navigate the fleet view by machine and open a machine's detail - #1722
Merged
Merged
Conversation
christianparpart
added
the
type/feature
github-actions
Bot
added
area/protocol
Signed-off-by: Christian Parpart <c.parpart@lastrada.net>
… and rows Up and Down walk the fleet view's chart lanes, then the active section's matched rows (StepFocus), over the counts the last frame drew. The machine the highlight names is dressed as Selected wherever it appears: its band's label and the first cell of every table row whose machine column names it, plus the focused row itself. Each frame clamps the focus to the lanes and rows it has before drawing, so a sample or filter that removes the focused row moves the highlight rather than losing it; a section switch or filter edit restarts a row focus on the first row, and a focused row is scrolled into view. Row matching is lifted into WriteMatchingRows, so the drawn table and the highlight count the same rows. FocusedMachine is public for the detail view that follows. Signed-off-by: Christian Parpart <c.parpart@lastrada.net>
The lanes Up and Down walk were read over the whole history while a text chart bands only the samples its cells hold. A machine that fell silent between the two spans was lane 0 in the list and in no band: the first Down dressed nothing and the last drawn band could not be reached. The view now records the chart's window with its band count and reads the lanes over it. Signed-off-by: Christian Parpart <c.parpart@lastrada.net>
…returns Enter on a highlight that names a machine draws that machine's detail in place of the tiles, chart, strip and table: a `machine <endpoint>` heading with its name, then every tabular section that names machines, restricted to that machine's rows through WriteMatchingRows (TableState gains restrictToMachine). A section with none of its rows writes the absent marker under its name, and a machine the latest sample no longer lists says `not in the latest sample`. Esc closes the detail and the focus is where it was; while it is open no other key acts. IDashboardView gains a pure ClaimsEscape, implemented by every view: the loop hands Esc (now the named EscapeKey) to a view that claims it rather than quitting. The strip's hint names the keys that select and open a machine, yielding first for width, and the rung glyphs spell the arrows as ASCII where the terminal is. Signed-off-by: Christian Parpart <c.parpart@lastrada.net>
…d samples right The final review of the fleet navigation branch found six things: - A failed sample nulls the latest document, and the detail heading read that as `not in the latest sample`. The note is now said only when a machines section was read and lists no such machine; with none read the heading carries the absent marker. - Every detail section was Essential, so a terminal of about 21 rows or fewer drew the minimum-size line. Each section is now one table item, its name a heading line above its columns (Item::heading), at a priority below Essential: tables shrink, then whole sections drop from the bottom, keeping the heading. A restricted table with no rows is the absent marker without the column-width check. - The detail dressed every row Selected. The restriction now travels as TableState::only (a RowMachine), never as the highlight's machine. - Docs say the detail's tables do not scroll; the QuitKeys and NamedKeys comments no longer contradict what Esc and the arrows now do; the filter's Esc row spells EscapeKey. - Tests pin that no key but Esc acts while a detail is open, that a second Esc quits, and that a focused row past the page is scrolled in. Signed-off-by: Christian Parpart <c.parpart@lastrada.net>
clang-tidy 22.1.8 refused two things on this branch: PlacedFrame's cognitive complexity (62, threshold 60) and EscapeClaimingView's public `offered` beside a private member. The per-frame clamp of the highlight and the machine it names is now FocusForFrame, a pure function over the frame's inputs and the walk state (FocusWalk -> FramedFocus); the fake keeps every member public, as the file's other recording fakes do. Signed-off-by: Christian Parpart <c.parpart@lastrada.net>
…off the site docs/superpowers/ holds the design and plan documents the agent workflow writes. They are local working files: ignored, never tracked, and excluded from the site so a local strict mkdocs build does not refuse them. Signed-off-by: Christian Parpart <c.parpart@lastrada.net>
christianparpart
force-pushed
the
design/fleet-operator-analytics
branch
from
October 20, 2026 18:44
6fda414 to
c459f3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
pacectl live-stats fleetgains keyboard navigation and a per-machine detail view, so an operator can investigate one machine without asking anybody to run a command on it./are unchanged.q/Ctrl-C quit everywhere. The dashboard loop now asks a viewClaimsEscape()(pure virtual onIDashboardView) before treating Esc as quit.not in the latest sample.This is Part B of the fleet operator analytics design. Part A (client reporting: why a build was not distributed, toolchain census, usage per machine) is a separate plan. Operator actions (tier management, machine labels) are deferred to #1720.
How
src/apps/pacectl/FleetFocus.{hpp,cpp}— a pure focus model:StepFocus,ClampFocus, andMachineColumnOf(anEnumTable<FleetSection, …>, each column checked against the leader'sFleetColumnNames).DashboardPanel.{hpp,cpp}—FocusStepKeys/DetailKeystables; one row matcher (WriteMatchingRows) shared by the table, the highlight and the detail; the lanes are read over the window the chart actually drew.DashboardLoop.{hpp,cpp}—EscapeKeynamed once;ClaimsEscapeon every view, test fakes included.docs/tools/pacectl.md— the new keys and the detail view..gitignore/mkdocs.yml—docs/superpowers/(the agent workflow's local design and plan files) is never tracked, and is excluded from a local strict site build.Testing
cl-debug: wholepacectl-testsbinary, 700 cases passing.scripts/local-gate.shin WSL (clang-format 22.1.8 and clang-tidy 22.1.8 pinned): clang-debug leg passed (build with clang-tidy, full ctest). gcc-release leg passed —LOCAL GATE PASSED. (An earlier run on a host whoseg++was anupdate-alternativeschain faileddist-compile-e2eon a launcher/worker fingerprint disagreement, in code this PR does not touch; filed as Toolchain fingerprint differs between launcher and worker when g++ is an update-alternatives chain #1721.)qexited 0.