Multi-day strain plots functionalized #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahhei
requested review from
C-1337ka and
keithshep
and removed request for
gautam-sabnis
C-1337ka
reviewed
Jul 2, 2025
|
|
||
| REQUIRED_METADATA = ['ExptNumber', 'sex', 'Strain'] | ||
| REQUIRED_METADATA = ['ExptNumber', 'Sex', 'Strain'] | ||
| # Extra metadata is nice to have but may not be identical per-animal and ID marking can't be used to pick out individuals from metadata yet... |
There was a problem hiding this comment.
Writing is not fully clear here; maybe try breaking the sentences up for clarity - "Extra metadata is nice to have but may not be identical between animals." and "ID marking is unable to be used to sort individuals from metadata"
C-1337ka
reviewed
Jul 2, 2025
|
|
||
| 3. **Metadata File from Tom** | ||
| - This is an Excel file containing experiment metadata (e.g., animal IDs, strain, sex, room, etc.). | ||
| - There are older versions of this file around the HPC. You can use the default one, but if you are analyzing experiments more recent than the date of this file (2023-09-07), you will not find them here. |
There was a problem hiding this comment.
This line could be rewritten for clarity. What do the older version of the file do for you? Where is the default file, is that what you're linking out to?
"Experiments analyzed after 2023-09-07 will not have their metadata captured in the default file shared above"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script to make plots for multi-day behavior.
Would like some feedback/review on general documentation. No need to test at this stage, I have run it on my two behaviors and it works pretty comprehensively at least with the B6-BTBR adult datasets.