Skip to content

Better error handling for kotlinx-coroutines-guava #4566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Better error handling for kotlinx-coroutines-guava #4566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions integration/kotlinx-coroutines-guava/src/ListenableFuture.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,13 +132,19 @@ public fun <T> ListenableFuture<T>.asDeferred(): Deferred<T> {
val deferred = CompletableDeferred<T>()
Futures.addCallback(this, object : FutureCallback<T> {
override fun onSuccess(result: T) {
runCatching { deferred.complete(result) }
.onFailure { handleCoroutineException(EmptyCoroutineContext, it) }
try {
deferred.complete(result)
} catch (e: Exception) {
handleCoroutineException(EmptyCoroutineContext, e)
}
}

override fun onFailure(t: Throwable) {
runCatching { deferred.completeExceptionally(t) }
.onFailure { handleCoroutineException(EmptyCoroutineContext, it) }
try {
deferred.completeExceptionally(t)
} catch (e: Exception) {
handleCoroutineException(EmptyCoroutineContext, e)
}
}
}, MoreExecutors.directExecutor())

Expand Down Expand Up @@ -268,6 +274,8 @@ private class ToContinuation<T>(
// Future. Anything else showing up here indicates a very fundamental bug in a
// Future implementation.
continuation.resumeWithException(e.nonNullCause())
} catch (e: CancellationException) {
continuation.cancel(e)
}
}
}
Expand Down