Fix handling of 422 responses where errors is a string - #1164
Merged
acrobat merged 1 commit intoAug 18, 2026
Conversation
Collaborator
|
Thank you @GrahamCampbell |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub sometimes returns a 422 response in which the
errorsproperty is a plain string rather than an array of error objects, for example when creating a commit status for a commit that cannot be found. The exception thrower currently iterates over that property unconditionally, so instead of throwing aValidationFailedExceptioncarrying the message from GitHub, it triggers a PHP warning about passing a string toforeach, which under most frameworks surfaces as anErrorExceptionand hides the real error. This change casts the property to an array before iterating, so a string is reported through the existing string handling branch, and adds a test case covering that response shape.