fix: restore terminal and flush session on fatal REPL errors - #54
Open
syf2211 wants to merge 1 commit into
Open
Conversation
Add a process-level crash handler that tears down the TUI, fsyncs the session JSONL, and prints a resume hint on uncaughtException or unhandledRejection. Detect startup crash loops via a boot marker so the next launch can skip plugins and MCP in safe mode. Fixes KlaatAI#30
Contributor
|
@syf2211 please fix the merge conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a process-level crash handler for the TUI so fatal errors during an interactive session restore the terminal, fsync the session JSONL, and print a resume hint before exiting non-zero. A boot marker under
~/.klaatai/detects startup crash loops so the next launch can skip plugins and MCP in safe mode.Motivation
Fixes #30. A fatal error mid-session currently leaves the terminal in a broken state (alt-screen, hidden cursor, mouse capture) and makes it harder for users to recover their session.
Changes
src/engine/crash-handler.ts:installCrashHandler()handlesuncaughtException/unhandledRejectionwith terminal teardown, session fsync, and resume hint; boot marker helpers for crash-loop detection.src/screens/repl.ts: Install handler at REPL entry (before MCP/plugins); gate MCP and plugin loading behind safe mode; clear boot marker once the REPL is ready.src/main.tsx: Detect boot crash loop, write boot marker only after auth succeeds, passsafeModeto REPL; align normal-exit resume hint toklaatai --resume.src/engine/crash-handler.test.ts: Unit tests for helpers and handler exit path.Tests
bun run typecheck— passbun test— 253 pass (including 5 new crash-handler tests)bun run build— passNotes
Fixes #30