fix(PaintWidget): fix widget deactivation when not painting#3573
Open
Jo-Byr wants to merge 1 commit into
Open
Conversation
Replace macro.VOID return by macro.EVENT_ABORT return in handleEvent to avoid call to deactivateAllWidgets in macros invoke
Collaborator
|
This was changed in #3000 maybe you need to check the usecase |
finetjul
reviewed
Jul 24, 2026
| ); | ||
| } else { | ||
| return macro.VOID; | ||
| return macro.EVENT_ABORT; |
Member
There was a problem hiding this comment.
if you are not "painting", what are you doing ? Why don't you want other widgets to "use" the event ?
Contributor
Author
There was a problem hiding this comment.
We're updating the cursor circle. But return model.hasFocus ? macro.EVENT_ABORT : macro.VOID; may be more appropriate.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
It was impossible to use paint mode in PaintWidget example.
Results
The problem is fixed.
Changes
Replaced macro.VOID return by macro.EVENT_ABORT return in handleEvent to avoid call to deactivateAllWidgets in macros invoke
PR and Code Checklist
npm run reformatto have correctly formatted code