fix(deps): remove brace-expansion@1.1.15 CVE via root dep upgrades#3567
Open
anupamme wants to merge 1 commit into
Open
fix(deps): remove brace-expansion@1.1.15 CVE via root dep upgrades#3567anupamme wants to merge 1 commit into
anupamme wants to merge 1 commit into
Conversation
Remove shelljs (runtime dep) and replace its three call sites in convert-cli.js with Node built-ins (fs.readdirSync, child_process.execSync). Replace commitizen with @commitlint/prompt-cli (commitizen@4.3.2 still pins glob@7.2.3 — no clean upgrade path). Upgrade patch-package 6→8 and @mapbox/node-pre-gyp 1→2, both of which dropped their rimraf→glob@7 chains. All four brace-expansion@1.x instances are gone from the lockfile. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
|
@finetjul is this DataGenerator cli still used/needed ? this PR is full made by AI, Claude even replaced the PR template with his own version. Are we ok with that ? the commit is Co-Authored by Claude ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
brace-expansion@1.1.15CVE by removing the four transitive dependency chains that pull it in, rather than using an npm override (as the previous PR #3566 attempted).shelljs/node_modules/brace-expansionshelljs@0.8.5 → glob@7 → minimatch@3commitizen/node_modules/brace-expansioncommitizen@4.3.1 → glob@7.2.3(pinned exact)@commitlint/prompt-cli@19.7.1(commitizen@4.3.2 still pins glob@7.2.3 — no upgrade path exists)patch-package/node_modules/brace-expansionpatch-package@6.4.7 → rimraf@2.7.1 → glob@7rimraf/node_modules/brace-expansion@mapbox/node-pre-gyp@1.0.9 → rimraf@3.0.2 → glob@7Changes:
shelljsremoved fromdependencies; its three call sites inUtilities/DataGenerator/convert-cli.jsreplaced withfs.readdirSync, a recursivefindAll()helper, andchild_process.execSynccommitizenreplaced with@commitlint/prompt-cliin devDependencies;npm run commitstill works (binary name iscommit); theconfig.commitizenblock removedpatch-packagebumped6.4.7 → 8.0.1; existingpatches/dox+1.0.0.patchapplies cleanly (verified)@mapbox/node-pre-gypbumped1.0.9 → 2.0.0Test plan
node -e "..."confirms zerobrace-expansion@1.xentries in the new lockfilenpm run build:pre— patch-package 8.0.1 appliesdox@1.0.0patch successfullynpm run build— full ESM + UMD buildnpm test— full test suitenpm run commit -- --help— smoke-test@commitlint/prompt-clilaunches🤖 Generated with Claude Code