Skip to content

chore(RemoteView): add dependencies to example readme - #3562

Closed
Jo-Byr wants to merge 1 commit into
Kitware:masterfrom
Jo-Byr:improve-remote-server-example-documentation
Closed

chore(RemoteView): add dependencies to example readme#3562
Jo-Byr wants to merge 1 commit into
Kitware:masterfrom
Jo-Byr:improve-remote-server-example-documentation

Conversation

@Jo-Byr

@Jo-Byr Jo-Byr commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Context

RemoteView's example fails due to a wslink version mismatch between js and Python. I added a specification of the necessary version in the README of the example.

Results

The example works locally. But it still does not on the example page since there's no remote view running. We should probably remove it from the page.

Changes

Added dependencies list in the example's README file

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

@Jo-Byr Jo-Byr changed the title chore(RemoteViewadd dependencies to example readme chore(RemoteView): add dependencies to example readme Jul 21, 2026
@Jo-Byr Jo-Byr self-assigned this Jul 21, 2026
@finetjul
finetjul requested a review from jourdain July 21, 2026 20:11
@jourdain

Copy link
Copy Markdown
Collaborator

Maybe, we should just bump wslink dependency in vtk.js so that the latest version of wslink would work everywhere?

https://www.npmjs.com/package/@kitware/wslink => 2.5.7

@jourdain

Copy link
Copy Markdown
Collaborator

The issue here is that the example get built with wslink<2 and therefore force the server to have a wslink<2. But if the example was built with wslink>=2, then the python will just work because the latest wslink will be picked up.

@Jo-Byr

Jo-Byr commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

we should just bump wslink dependency

Is updating the version enough or are there changes to do in WSLinkClient ? wslink does not seem to used anywhere else than this class and RemoteView, and the latter works fine with a simple version bump

@jourdain

Copy link
Copy Markdown
Collaborator

updating the version should be enough. The "breaking change" is internal and just impose the matching (1 vs 2) version on the server.

@Jo-Byr

Jo-Byr commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

I created a PR to bump wslink, I'll close this PR.

@Jo-Byr Jo-Byr closed this Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants