Conversation
onResize reset every pane whose container changed size, so anything that resized the annotator -- opening a context panel from the sidebar, the controls strip growing a row -- threw away the zoom the reviewer had set. Each pane now remembers the view its last reset produced: the per-pane native fit, or the Align View reference fit when the aggregate reset goes through the aligned override. On a resize, a pane still at that view refits to the new size as before, and a pane the user has zoomed or panned keeps its zoom and center.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onResize reset every pane whose container changed size, so anything that resized the annotator -- opening a context panel from the sidebar, the controls strip growing a row -- threw away the zoom the reviewer had set.
Each pane now remembers the view its last reset produced: the per-pane native fit, or the Align View reference fit when the aggregate reset goes through the aligned override. On a resize, a pane still at that view refits to the new size as before, and a pane the user has zoomed or panned keeps its zoom and center.
This is the most subjective change of the 3, but I find it very jarring to zoom in on an object, and say, open the advanced tools to change the image enhancements, and completely reset the zoom. But, if this is standard flow happy to remove it.