Add time filter persistence, text inputs, and overlay settings panel#1592
Open
mattdawkins wants to merge 9 commits intomainfrom
Open
Add time filter persistence, text inputs, and overlay settings panel#1592mattdawkins wants to merge 9 commits intomainfrom
mattdawkins wants to merge 9 commits intomainfrom
Conversation
mattdawkins
force-pushed
the
filter-range-in-pipes-and-adj-opt
branch
from
05f3341 to
f1e0542
Compare
Save and load timeFilters in dataset metadata following the established confidenceFilters pattern. Filters are saved on every change (toggle, slider, timeline drag) and restored when the dataset is reopened.
Replace the hover-based v-menu with a click-toggled overlay panel that appears above the controls bar on the right third of the screen. Add frame number text fields and HH:MM:SS time inputs (for video datasets) alongside the existing sliders. Clicking the filter button enables the filter and opens settings; clicking again disables it; clicking outside closes the panel without disabling.
Pass start_frame, end_frame, and frame_range_is_native to the KWIVER downsampler when the user has selected a frame range, so VIAME skips frames outside the range rather than post-filtering. The is_native flag is set based on whether DIVE is downsampling (fps < originalFps).
…ne type For transcode/filter pipelines with a frame range, renumber output frames relative to the new range (frame 0 = start frame). For all other pipelines, keep frames relative to the original video.
mattdawkins
force-pushed
the
filter-range-in-pipes-and-adj-opt
branch
2 times, most recently
from
d47d5d0 to
3f82c93
Compare
Collaborator
|
I've updated the system to use PipelineParams and that type has RunTimeParams like the frameRange and KwiverParams are params passed into kwiver. @mattdawkins - I've ran a simple fish detector on this and the output produces two files. A detector_output.csv and a detector_output_filtered.csv, the filtered file typically has no tracks. The detector_output has tracks but the frame Ids are reset to 0 and not the range where they shgould be. I tried setting the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Persist time filters per dataset, expose them as text inputs in the overlay panel, and have pipelines respect the active filter range.
Changes vs main